Subscribe: lkml.org
http://lkml.org/rss.php
Added By: Feedage Forager Feedage Grade B rated
Language: English
Tags:
bian bianpan  bian  bianpan  drivers  file changed  git  net  pan bian  pan  patch  struct  summary  writes summary  writes 
Rate this Feed
Rate this feedRate this feedRate this feedRate this feedRate this feed
Rate this feed 1 starRate this feed 2 starRate this feed 3 starRate this feed 4 starRate this feed 5 star

Comments (0)

Feed Details and Statistics Feed Statistics
Preview: lkml.org

lkml.org



lkml.org - the realtime linux kernel mailinglist archive



Last Build Date: Sun, 04 Dec 2016 11:24:52 +0100

 






Re: alpha: Checking for a failed kmalloc() in process_reloc_for_got()?
SF Markus Elfring writes: *drumroll* it'd actually be a proper bugfix.
Which kind of exception handling can be added here when the function “process_reloc_for_got” has got the return type “void” so far? “process_reloc_for_got” has got the return type “void” so far? Will it be needed to handle such a software failure at more source code places by a special error code?
by a special error code?
Regards,
Markus
Markus
Markus



Re: [PATCH 1/1] isdn: hisax: set error code on failure
Sergei Shtylyov writes: Hello.
Hello.
On 12/4/2016 8:15 AM, Pan Bian wrote:
On 12/4/2016 8:15 AM, Pan Bian wrote:
+ err = -ENOMEM;
-EBUSY fits request_region() better.
-EBUSY fits request_region() better.
[..]
[..]
MBR, Sergei
MBR, Sergei
MBR, Sergei



Re: [PATCH 1/1] edac: fix improper return value
Borislav Petkov writes: On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote: Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 That bugzilla entry wasn't really needed.
That bugzilla entry wasn't really needed.
1 file changed, 1 insertion(+), 1 deletion(-)
Applied,
thanks.
thanks.



[PATCH 2/2] Staging: ks7010: eap_packet.h: fixed coding style issue
Manoj Sawai writes: (Summary) 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index df7f760e4110..45d30b8ed0b1 100644 --- a/drivers/staging/ks7010/eap_packet.h +++ b/drivers/staging/ks7010/eap_packet.h @@ -58,12 +58,15 @@ struct ieee802_1x_eapol_key { * encrypt the Key field; /* * key flag in the most significant bit: * 0 = broadcast (default key), - * 1 = unicast (key mapping key); key index is in the - * 7 least significant bits + * 1 = unicast (key mapping key);



[PATCH] Staging: ks7010: ks7010_stio.h: fixed coding style error
Manoj Sawai writes: (Summary) 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 0a0951ffffa6..0f5fd848e23d 100644 --- a/drivers/staging/ks7010/ks7010_sdio.h +++ b/drivers/staging/ks7010/ks7010_sdio.h @@ -1,5 +1,5 @@ /* - * Driver for KeyStream, KS7010 based SDIO cards. @@ -41,7 +41,7 @@ /* Write Index Register */ #define WRITE_INDEX 0x000010 -/* Write Status/Read Data Size Register +/* Write Status/Read Data Size Register * for network packet (less than 2048 bytes data) */ #define WSTATUS_RSIZE 0x000014 -- 2.11.0



Re: [PATCH] Input: mouse: synaptics - change msleep to usleep_rang ...
Igor Grinberg writes: (Summary) Hi Aniroop Mathur,
Hi Aniroop Mathur,
On 11/29/16 23:02, Aniroop Mathur wrote:
of individuals who could support to test it?
This touchpad and the driver was used on an old PXA270 based PDA. (~20 ms actual sleep for any value given in the 1~20ms range) Well, it should be at least 1ms as stated in my comment just before the define. So, there should be no issue from correctness POV.
So, there should be no issue from correctness POV.
Thus, change msleep to usleep_range for precise wakeups. IMHO, there is no need for precise wakeups for this device, so I wouldn't bother.
bother.
2.6.2



[PATCH] perf/core: remove invalid warning from list_update_cgroup_ ...
David Carrillo-Cisneros writes: (Summary) The warning introduced in commit:
The warning introduced in commit:
979bfef8607c ("perf/core: Do not set cpuctx->cgrp for unscheduled cgroups") 979bfef8607c ("perf/core: Do not set cpuctx->cgrp for unscheduled cgroups") assumed that a cgroup switch always precedes list_del_event. */ - if (perf_cgroup_from_task(current, ctx) != event->cgrp) { - /* - * We are removing the last cpu event in this context. - } - cpuctx->cgrp = add ? + /* + * cpuctx->cgrp is NULL until a cgroup event is sched in or + * ctx->nr_cgroup == 0 .



[PATCH 1/1] net: bnx2x: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 0cee4c0..6f9fc20 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -13505,6 +13505,7 @@ static int bnx2x_init_firmware(struct bnx2x *bp) /* Initialize the pointers to the init arrays */ /* Blob */ + rc = -ENOMEM;



Re: [PATCH] trace: extend trace_clock to support arch_arm clock co ...
Srinivas Ramana writes: (Summary) On 12/02/2016 04:38 PM, Will Deacon wrote:
Will
Having cycle counter would help in the cases where we want to correlate the time with other subsystems which are outside cpu subsystem. Yes, they are backed up by the architected counter but they ignore the cycles spent in suspend. so, when comparing with monotonically increasing cycle counter, other clocks doesn't help. It seems X86 uses the TSC counter to help such cases. It seems X86 uses the TSC counter to help such cases.



make[2]: *** No rule to make target 'arch/sh/boot/dts/.dtb.o', nee ...
kbuild test robot writes: (Summary) Hi Rich,
Hi Rich,
FYI, the error/warning still remains.
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531
commit: 190fe191cfbead9fe089453dd092869c9469c6d4 sh: add support for linking a builtin device tree blob in the kernel date: 4 months ago
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout 190fe191cfbead9fe089453dd092869c9469c6d4 # save the attached .config to linux build tree
make.cross ARCH=sh
ma



Re: [linux-sunxi] [PATCH v3 -next 2/2] ARM: dts: sunxi: add suppor ...
Alexey Kardashevskiy writes: On 03/12/16 03:41, Chen-Yu Tsai wrote:
AFAIK this board doesn't have an actual USB port.
AFAIK this board doesn't have an actual USB port.
Mine does have one port.
Mine does have one port.
Mine does have one port.
For more options, visit https://groups.google.com/d/optout. For more options, visit https://groups.google.com/d/optout.



RE: [RESEND PATCH V6 0/6] Add support for privileged mappings
"Sricharan" writes: (Summary) Hi Robin,
Hi Robin,
that branch :)
Sure, i did not knew that you were on this already. I am fine with either ways that you suggest.
that you suggest.
I checked the patches against your branch, i see that the changes are, I checked the patches against your branch, i see that the changes are, 1) one patch for implementing it for armv7s descriptor 2) Changes on pl330 patch commit logs and
3) One patch for doing the revert on arm-smmuv3 as well. Regards,
Sricharan
Sricharan
Sricharan
Sricharan



Re: [PATCH] x86/kbuild: enable modversions for symbols exported fr ...
Alan Modra writes: (Summary) On Fri, Dec 02, 2016 at 11:55:58AM +0100, Arnd Bergmann wrote: to a weak symbol in vmlinux. Am I correct in thinking that remained true up until Linus' merge commit 84d69848c9 2016-10-14? You can see how important I think the fix was by viewing https://sourceware.org/bugzilla/show_bug.cgi?id=4317 and noticing that the bug was reported in 2007 and didn't see any action for 8 years..
for 8 years..



Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __ ...
"Neftin, Sasha" writes: (Summary) On 12/2/2016 7:02 PM, Baicar, Tyler wrote:
Hello Tyler,
We do not tried reproduce issues yet. As I know hit on BUG_ON happen on very old NIC. Our more new NIC do not experienced such problem. I would like recommend do not change kernel code in this moment. This is very sensitive for a driver state machine and we afraid from opening lot of issues. I will investigate more depth this problem later(hope have a time for it) and let you know if we have suggest fixes for this problem. Thanks,
Sasha
Sasha
Sasha



Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value
Leon Romanovsky writes: On Sun, Dec 04, 2016 at 02:45:38PM +0800, Pan Bian wrote: Signed-off-by: Pan Bian Thanks,
Reviewed-by: Leon Romanovsky Reviewed-by: Leon Romanovsky [unhandled content-type:application/pgp-signature]



[PATCH 1/1] infiniband: hw: mlx4: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
If uhw->inlen is non-zero, the value of variable err is 0 if the copy succeeds. This patch fixes the bug, assign "-ENOMEM" to err before the NULL pointer checks, and remove the initialization of err at the beginning.
beginning.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189031 Signed-off-by: Pan Bian 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index b597e82..a87c395 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -430,7 +430,7 @@ static int mlx4_ib_query_device(struct ib_device *ibdev, struct mlx4_ib_dev *dev = to_mdev(ibdev);



arch/xtensa/include/asm/initialize_mmu.h:41: Error: invalid regist ...
kbuild test robot writes: (Summary) Hi Pete,
Hi Pete,
FYI, the error/warning still remains.
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531
commit: d0b73b488c55df905ea8faaad079f8535629ed26 xtensa: Add config files for Diamond 233L - Rev C processor variant date: 3 years, 9 months ago
config: xtensa-generic_kc705_defconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout d0b73b488c55df905ea8faaad079f8535629ed26 # save the attached .config to linux build tree
make.cross ARCH=xtensa



[PATCH 1/1] net: ethernet: broadcom: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 0cee4c0..6f9fc20 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -13505,6 +13505,7 @@ static int bnx2x_init_firmware(struct bnx2x *bp) /* Initialize the pointers to the init arrays */ /* Blob */ + rc = -ENOMEM;



[PATCH 1/1] xen: set error code on failures
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
The return variable rc is initialized with "-ENOMEM" outside the loop. 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c index 7a47c4c..55ef246 100644 --- a/drivers/xen/gntalloc.c +++ b/drivers/xen/gntalloc.c @@ -130,15 +130,19 @@ static int add_grefs(struct ioctl_gntalloc_alloc_gref *op, rc = -ENOMEM; - if (!gref) + if (!gref) { + rc = -ENOMEM;



Re: [PATCH 1/1] infiniband: hw: ocrdma: fix bad initialization
Leon Romanovsky writes: On Sat, Dec 03, 2016 at 09:10:21PM +0800, Pan Bian wrote: Signed-off-by: Pan Bian Thanks,
Reviewed-by: Leon Romanovsky Reviewed-by: Leon Romanovsky [unhandled content-type:application/pgp-signature]



[PATCH 1/1] mtd: ubi: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When __vmalloc() returns a NULL pointer, the region is not checked, and we cannot make sure that only 0xFF bytes are present at offset. 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c index b6fb8f9..b54fe05 100644 --- a/drivers/mtd/ubi/io.c +++ b/drivers/mtd/ubi/io.c @@ -1413,7 +1413,7 @@ int ubi_self_check_all_ff(struct ubi_device *ubi, int pnum, int offset, int len) buf = __vmalloc(len, GFP_NOFS, PAGE_KERNEL);



[PATCH 1/1] net: ethernet: qlogic: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When the call to qlcnic_alloc_mbx_args() fails, returning variable "err" seems improper. 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index bdbcd2b..21c4aca 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -3189,7 +3189,7 @@ int qlcnic_83xx_test_link(struct qlcnic_adapter *adapter) err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_GET_LINK_STATUS);



Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value
Leon Romanovsky writes: (Summary) On Sun, Dec 04, 2016 at 01:49:04PM +0800, Pan Bian wrote: goto out;
In such case, the err initialization at the beginning of mlx4_ib_query_device function is not necessary. mlx4_ib_query_device function is not necessary. Besides that, look good.
Reviewed-by: Leon Romanovsky Reviewed-by: Leon Romanovsky More majordomo info at http://vger.kernel.org/majordomo-info.html[unhandled content-type:application/pgp-signature]



[PATCH 1/1] net: ethernet: qlogic: set error code on failure
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When calling dma_mapping_error(), the value of return variable rc is 0. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index f95385c..62ae55b 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -1730,6 +1730,7 @@ static int qed_ll2_start_xmit(struct qed_dev *cdev, struct sk_buff *skb) mapping))) { DP_NOTICE(cdev, "Unable to map frag - dropping packet\n");



Re: [PATCH v3 07/13] net: ethernet: ti: cpts: clean up event list ...
kbuild test robot writes: (Summary) Hi WingMan,
Hi WingMan,
[auto build test ERROR on net/master]
[also build test ERROR on v4.9-rc7 next-20161202]
[cannot apply to net-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Grygorii-Strashko/net-ethernet-ti-cpts-switch-to-readl-writel_relaxed/20161204-010355 config: arm-omap2plus_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.



[PATCH 1/1] edac: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When the call to zalloc_cpumask_var() fails, returning "false" seems improper. 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index ee181c5..72a2c75 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -2539,7 +2539,7 @@ static int toggle_ecc_err_reporting(struct ecc_settings *s, u16 nid, bool on) if (!zalloc_cpumask_var(&cmask, GFP_KERNEL)) { amd64_warn("%s: error allocating mask\n", __func__);



[PATCH 1/1] scsi: snic: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When the calls to mempool_create_slab_pool() return unexpected values, the value of return variable ret is 0. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/snic/snic_main.c b/drivers/scsi/snic/snic_main.c index 396b32d..e8907e6 100644 --- a/drivers/scsi/snic/snic_main.c +++ b/drivers/scsi/snic/snic_main.c @@ -586,6 +586,7 @@ for (i = 0;



[PATCH 1/1] scsi: fnic: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When the calls to mempool_create_slab_pool() return unexpected values, the value of return variable err is 0. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index 58ce902..389c13e 100644 --- a/drivers/scsi/fnic/fnic_main.c +++ b/drivers/scsi/fnic/fnic_main.c @@ -735,6 +735,7 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) for (i = 0;



[PATCH 1/1] infiniband: hw: mlx4: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
If uhw->inlen is non-zero, the value of variable err is 0 if the copy succeeds. This patch fixes the bug, assigning "-ENOMEM" to err before the NULL pointer checks.
the NULL pointer checks.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189031 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189031 Signed-off-by: Pan Bian 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index b597e82..f6c5158 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -455,6 +455,7 @@ static int mlx4_ib_query_device(struct ib_device *ibdev, sizeof(resp.response_length);



[PATCH 1/1] atm: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
It returns variable "error" when ioremap_nocache() returns a NULL pointer. This patch fixes the bug, returning "-ENOMEM".
"-ENOMEM".
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021 Signed-off-by: Pan Bian 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index f2aaf9e..40c2d56 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -1727,7 +1727,7 @@ static int eni_do_init(struct atm_dev *dev) printk("\n");



[PATCH 1/1] media: pci: meye: set error code on failures
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
The value of return variable ret is 0 on some error paths, for example, when pci_resource_start() returns a NULL pointer. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c index ba887e8..115e141 100644 --- a/drivers/media/pci/meye/meye.c +++ b/drivers/media/pci/meye/meye.c @@ -1669,6 +1669,7 @@ static int meye_probe(struct pci_dev *pcidev, const struct pci_device_id *ent) goto outenabledev;



[PATCH 1/2] scsi: be2iscsi: set errno on error path
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
Variable ret is reset in the loop, and its value will be 0 during the second and after repeat of the loop. 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index d9239c2..b6c5791 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3113,8 +3113,10 @@ static int beiscsi_create_cqs(struct beiscsi_hba *phba, cq_vaddress = pci_alloc_consistent(phba->pcidev, num_cq_pages * PAGE_SIZE, &paddr);



[PATCH 1/1] media: pci: meye: set error code on failures
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
The value of return variable ret is 0 on some error paths, for example, when pci_resource_start() returns a NULL pointer. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c index ba887e8..115e141 100644 --- a/drivers/media/pci/meye/meye.c +++ b/drivers/media/pci/meye/meye.c @@ -1669,6 +1669,7 @@ static int meye_probe(struct pci_dev *pcidev, const struct pci_device_id *ent) goto outenabledev;



[PATCH 1/1] scsi: 3w-sas: set errno on failures
Pan Bian writes: (Summary) 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index f837485..65b42b4 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -1600,6 +1600,7 @@ static int twl_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id) if (twl_initialize_device_extension(tw_dev)) { TW_PRINTK(tw_dev->host, TW_DRIVER, 0x1a, "Failed to initialize device extension"); } @@ -1623,6 +1625,7 @@ static int twl_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id) /* Initialize the card */ if (twl_reset_sequence(tw_dev, 0)) { TW_PRINTK(tw_dev->host, TW_DRIVER, 0x1d, "Controller reset failed during probe");



[PATCH 1/1] memstick: host: fix improper return value
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When pci_ioremap_bar() returns a NULL pointer, the value of return variable "error" is 0. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c index d5cfb50..eebed0a 100644 --- a/drivers/memstick/host/r592.c +++ b/drivers/memstick/host/r592.c @@ -761,6 +761,7 @@ static int r592_probe(struct pci_dev *pdev, const struct pci_device_id *id) if (error) goto error3;



include/linux/bug.h:37:45: error: bit-field '' width no ...
kbuild test robot writes: (Summary) ((n) - 1)) != 0)) 35edd9103 Paul Gortmaker 2011-11-16 32 35edd9103 Paul Gortmaker 2011-11-16 33 /* Force a compilation error if condition is true, but also produce a 35edd9103 Paul Gortmaker 2011-11-16 34 result (of value 0 and type size_t), so the expression can be used 35edd9103 Paul Gortmaker 2011-11-16 35 e.g.



[PATCH 1/1] net: irda: set error code on failures
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
When the calls to kzalloc() fail, the value of return variable ret may be 0. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c index a198946..8716b8c 100644 --- a/drivers/net/irda/irda-usb.c +++ b/drivers/net/irda/irda-usb.c @@ -1723,6 +1723,7 @@ static int irda_usb_probe(struct usb_interface *intf, /* Don't change this buffer size and allocation without doing * some heavy and complete testing.



[PATCH 2/2] scsi: be2iscsi: set errno on error path
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
Variable ret is reset in the loop, and its value will be 0 during the second and after repeat of the loop. 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index b6c5791..b5112d6 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -3049,8 +3049,10 @@ static int beiscsi_create_eqs(struct beiscsi_hba *phba, eq_vaddress = pci_alloc_consistent(phba->pcidev, num_eq_pages * PAGE_SIZE, &paddr);



[PATCH 1/1] isdn: hisax: set error code on failure
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
In function hfc4s8s_probe(), the value of return variable err should be negative on failures. 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c index 9600cd7..3172cee 100644 --- a/drivers/isdn/hisax/hfc4s8s_l1.c +++ b/drivers/isdn/hisax/hfc4s8s_l1.c @@ -1499,6 +1499,7 @@ struct hfc4s8s_l1 { printk(KERN_INFO "HFC-4S/8S: failed to request address space at 0x%04x\n", hw->iobase);



[PATCH 1/1] input: usbhid: fix improper check
Pan Bian writes: (Summary) From: Pan Bian
From: Pan Bian
Function hid_post_reset() returns 0 on success, or 1 on failures. This patch fixes the bug, uses "status == 0" to check the return value.
return value.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188921 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188921 Signed-off-by: Pan Bian 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index ae83af6..3639b70 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -1590,7 +1590,7 @@ static int hid_reset_resume(struct usb_interface *intf) int status;



Re: [PATCH 1/1] net: dcb: set error code on failures
David Miller writes: From: Pan Bian
Date: Sat, 3 Dec 2016 21:49:08 +0800
Date: Sat, 3 Dec 2016 21:49:08 +0800
Signed-off-by: Pan Bian Applied, thanks.
Applied, thanks.
Applied, thanks.



[PATCH 1/1] btrfs: fix improper return value
Pan Bian writes: (Summary) In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret on errors. This patch also removes the warning, because the caller already prints a warning.
prints a warning.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Signed-off-by: Pan Bian 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/btrfs/uuid-tree.c b/fs/btrfs/uuid-tree.c index 7fc89e4..83bb2f2 100644 --- a/fs/btrfs/uuid-tree.c +++ b/fs/btrfs/uuid-tree.c @@ -351,7 +351,5 @@ int btrfs_uuid_tree_iterate(struct btrfs_fs_info *fs_info, out: btrfs_free_path(path); - if (ret) - btrfs_warn(fs_info, "btrfs_uuid_tree_iterate failed %d", ret);



Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'
David Miller writes: (Summary) From: Arnd Bergmann
Date: Sat, 3 Dec 2016 00:04:32 +0100
Date: Sat, 3 Dec 2016 00:04:32 +0100
Signed-off-by: Arnd Bergmann
Like the kbuild robot, when I apply this it complains about 'imply' being an unknown option.
an unknown option.
I guess it worked for you because support for 'imply' exists in the -next tree and gets pulled in from somewhere else.
tree and gets pulled in from somewhere else.
In any event, as-is I cannot apply this.
In any event, as-is I cannot apply this.
In any event, as-is I cannot apply this.



Re: [PATCH 1/4] statx: Add a system call to make enhanced file inf ...
Al Viro writes: (Summary) + * vfs_xgetattr - Get the enhanced basic attributes of a file > + * @path: The file of interest > + * @stat: Where to return the statistics > + * If the file is remote, the filesystem can be forced to update the attributes > + * from the backing store by passing AT_FORCE_ATTR_SYNC in query_flags or can > + * Bits must have been set in stat->request_mask to indicate which attributes > + * returned anyway, but the value may be approximate, and, if remote, may not >



Re: [PATCH] dt-binding: soc: qcom: smd: Add label property
Andy Gross writes: On Wed, Oct 26, 2016 at 05:08:20PM -0500, Rob Herring wrote: Acked-by: Rob Herring
Acked-by: Andy Gross
Acked-by: Andy Gross
Acked-by: Andy Gross



[PATCH 1/1] net: caif: remove ineffective check
Pan Bian writes: (Summary) The check of the return value of sock_register() is ineffective. 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c index aa209b1..92cbbd2 100644 --- a/net/caif/caif_socket.c +++ b/net/caif/caif_socket.c @@ -1107,10 +1107,7 @@ static int caif_create(struct net *net, struct socket *sock, int protocol, static int __init caif_sktinit_module(void) { - int err = sock_register(&caif_family_ops); - if (!err) - return err;



cc1: error: '-march=r3900' requires '-mfp32'
kbuild test robot writes: (Summary) Hi James,
Hi James,
FYI, the error/warning still remains.
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531
commit: 034827c727f7f3946a18355b63995b402c226c82 MIPS: Fix -mabi=64 build of vdso.lds date: 8 weeks ago
config: mips-jmr3927_defconfig (attached as .config) compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout 034827c727f7f3946a18355b63995b402c226c82 # save the attached .config to linux build tree
make.cross ARCH=mips
make.cross ARCH=mips
A



Re: [PATCH 1/4] statx: Add a system call to make enhanced file inf ...
Al Viro writes: (Summary) On Wed, Nov 23, 2016 at 12:55:51AM +0000, David Howells wrote: > -int vfs_getattr_nosec(struct path *path, struct kstat *stat) > +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat) const struct path *, please. > +int vfs_xgetattr(struct path *path, struct kstat *stat) Ditto. > +int vfs_getattr(struct path *path, struct kstat *stat) Again. > +#define __put_timestamp(kts, uts) ( \ > \ > \ > > +#define KSTAT_ATTR_FS_IOC_FLAGS 0x00000874 /* Attrs corresponding to FS_*_FL flags */ Err...



Re: [PATCH V4 2/2] pinctrl: tegra: Add driver to configure voltage ...
kbuild test robot writes: (Summary) Hi Laxman,
Hi Laxman,
[auto build test ERROR on tegra/for-next]
[also build test ERROR on v4.9-rc7 next-20161202]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Laxman-Dewangan/pinctrl-tegra-Add-DT-binding-for-io-pads-control/20161124-185652 base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit



cc1: error: '-march=r3000' requires '-mfp32'
kbuild test robot writes: (Summary) Hi James,
Hi James,
FYI, the error/warning still remains.
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5
commit: 034827c727f7f3946a18355b63995b402c226c82 MIPS: Fix -mabi=64 build of vdso.lds date: 8 weeks ago
config: mips-decstation_defconfig (attached as .config) compiler: mipsel-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout 034827c727f7f3946a18355b63995b402c226c82 # save the attached .config to linux build tree
make.cross ARCH=mips
make.cross ARCH=mips



[PATCH] zram: restrict add/remove attributes to root only
Sergey Senozhatsky writes: (Summary) 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 5163c8f..ee03464 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1414,8 +1414,8 @@ static ssize_t hot_remove_store(struct class *class, } static struct class_attribute zram_control_class_attrs[] = { - __ATTR_RO(hot_add), - __ATTR_WO(hot_remove), + __ATTR(hot_add, 0400, hot_add_show, NULL), + __ATTR(hot_remove, 0200, NULL, hot_remove_store), __ATTR_NULL, };



Urgent Pls
"Dr. Andrea" writes: (Summary) As y= ou already know, nothing can undermine a business relationship more complet= ely than lack of trust because trust is the essential precondition upon whi= ch all real success depends and the key to trust is action and commitments.= Commitments made and commitments honored.
Commitments made and commitments honored.
Once you agree to this, we shall sign the Equity Investment Agreement where= we shall state the profit sharing pattern and all other conditions.



Re: [PATCH v5 1/1] crypto: add virtio-crypto driver
kbuild test robot writes: (Summary) f5e706ad include/asm-sparc/topology_64.h Sam Ravnborg 2008-07-17 40 f5e706ad include/asm-sparc/topology_64.h Sam Ravnborg 2008-07-17 41 #endif /* !(CONFIG_NUMA) */ f5e706ad include/asm-sparc/topology_64.h Sam Ravnborg 2008-07-17 42 f5e706ad include/asm-sparc/topology_64.h Sam Ravnborg 2008-07-17 43 #ifdef CONFIG_SMP f5e706ad include/asm-sparc/topology_64.h Sam Ravnborg 2008-07-17 @44 #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id) f5e706ad include/asm-sparc/topology_64.h Sam Ravnborg 2008-07-17 45 #define topology_core_id(cpu) (cpu_data(cpu).core_id) acc455cf arch/sparc/include/asm/topology_64.h chris hyser 2015-04-22 46 #define topology_core_cpumask(cpu) (&cpu_core_sib_map[cpu]) 06931e62 arch/sparc/include/asm/topology_64.h Bartosz Golaszewski 2015-05-26 47 #define topology_sibling_cpumask(cpu) (&per_cpu(cpu_sibling_map, cpu)) f5e706ad include/asm-sparc/topology_64.h Sam Ravnbo



[PATCH 04/19] staging: iio: isl29028: add power management support
Brian Masney writes: (Summary) + + if (chip->suspended) { + ret = -EBUSY; + } + switch (chan->type) { case IIO_PROXIMITY: if (mask != IIO_CHAN_INFO_SAMP_FREQ) { @@ -322,6 +329,8 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, dev_err(dev, "Unsupported channel type\n"); + + if (chip->suspended) { + ret = -EBUSY; static struct i2c_driver isl29028_driver = { .driver = { .name = "isl29028", + .pm = &isl29028_pm_ops, .of_match_table = isl29028_of_match, }, .probe = isl29028_probe, -- 2.7.4



[PATCH 07/19] staging: iio: isl29028: fix alignment of function ar ...
Brian Masney writes: (Summary) 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index fe8814b..38027ee 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -115,7 +115,7 @@ static int isl29028_set_als_scale(struct isl29028_chip *chip, int lux_scale) ISL29028_CONF_ALS_RANGE_LOW_LUX; } static int isl29028_set_als_ir_mode(struct isl29028_chip *chip, @@ -147,7 +147,8 @@ static int isl29028_set_als_ir_mode(struct isl29028_chip *chip, case ISL29028_MODE_NONE: return regmap_update_bits(chip->regmap, ISL29028_REG_CONFIGURE, - ISL29028_CONF_ALS_EN_MASK, ISL29028_CONF_ALS_DIS);



[PATCH 05/19] staging: iio: isl29028: made alignment of #defines c ...
Brian Masney writes: (Summary) ISL29028_CONF_PROX_SLP_SH) -#define ISL29028_CONF_PROX_EN BIT(7) -#define ISL29028_CONF_PROX_EN_MASK BIT(7) +#define ISL29028_CONF_PROX_EN BIT(7) +#define ISL29028_CONF_PROX_EN_MASK BIT(7) -#define ISL29028_REG_INTERRUPT 0x02 +#define ISL29028_REG_INTERRUPT 0x02 -#define ISL29028_REG_PROX_DATA 0x08 -#define ISL29028_REG_ALSIR_L 0x09 -#define ISL29028_REG_ALSIR_U 0x0A +#define ISL29028_REG_PROX_DATA 0x08 +#define ISL29028_REG_ALSIR_L 0x09 +#define ISL29028_REG_ALSIR_U 0x0A -#define ISL29028_REG_TEST1_MODE 0x0E -#define ISL29028_REG_TEST2_MODE 0x0F +#define ISL29028_REG_TEST1_MODE 0x0E +#define ISL29028_REG_TEST2_MODE 0x0F -#define ISL29028_NUM_REGS (ISL29028_REG_TEST2_MODE + 1) +#define ISL29028_NUM_REGS (ISL29028_REG_TEST2_MODE + 1) enum isl29028_als_ir_mode { ISL29028_MODE_NONE = 0, -- 2.7.4



[PATCH 06/19] staging: iio: isl29028: made alignment of variables ...
Brian Masney writes: (Summary) The alignment of the variables in the struct isl29028_chip is not consistent. This changes all of the variables to use consistent alignment to improve the code readability.
alignment to improve the code readability.
Signed-off-by: Brian Masney 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index d5b069e..fe8814b 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -67,13 +67,13 @@ enum isl29028_als_ir_mode { }; struct isl29028_chip { - struct mutex lock; - struct regmap *regmap;



[PATCH 08/19] staging: iio: isl29028: combine isl29028_proxim_get( ...
Brian Masney writes: (Summary) 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 38027ee..fa2b283 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -200,6 +200,13 @@ static int isl29028_read_proxim(struct isl29028_chip *chip, int *prox) unsigned int data; 0) { dev_err(dev, "Error in reading register %d, error %d\n", @@ -210,19 +217,6 @@ static int isl29028_read_proxim(struct isl29028_chip *chip, int *prox) return 0; - - if (!chip->enable_prox) { - ret = isl29028_enable_proximity(chip);



[PATCH 11/19] staging: iio: isl29028: made column alignment in isl ...
Brian Masney writes: (Summary) 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 0e727ba..218d165 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -419,14 +419,16 @@ static const struct iio_chan_spec isl29028_channels[] = { { .type = IIO_LIGHT, .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) | - BIT(IIO_CHAN_INFO_SCALE), - }, { + BIT(IIO_CHAN_INFO_SCALE), + }, + { .type = IIO_INTENSITY, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), - }, { + }, + { .type = IIO_PROXIMITY, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |



[PATCH 09/19] staging: iio: isl29028: change newlines to improve r ...
Brian Masney writes: (Summary) 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index fa2b283..8f9295f 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -69,10 +69,8 @@ enum isl29028_als_ir_mode { struct isl29028_chip { struct mutex lock; 0) { dev_err(dev, @@ -296,9 +302,9 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, ret); 0) { dev_err(&client->dev, @@ -536,6 +547,7 @@ static int isl29028_probe(struct i2c_client *client, indio_dev->name = id->name; 0) { dev_err(&client->dev, @@ -543,6 +555,7 @@ static int isl29028_probe(struct i2c_client *client, ret);



[PATCH 10/19] staging: iio: isl29028: remove unused define ISL2902 ...
Brian Masney writes: (Summary) The #define ISL29028_DEV_ATTR was not used so this patch removes the unnecessary code.
unnecessary code.
Signed-off-by: Brian Masney 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 8f9295f..0e727ba 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -404,7 +404,6 @@ static IIO_CONST_ATTR(in_proximity_sampling_frequency_available, "1 3 5 10 13 20 83 100");



[PATCH 12/19] staging: iio: isl29028: fix comparison between signe ...
Brian Masney writes: (Summary) Fixed warning found by make W=2 to reduce the amount of build noise: Fixed warning found by make W=2 to reduce the amount of build noise: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
[-Wsign-compare]
Signed-off-by: Brian Masney 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 218d165..23a4db8 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -80,7 +80,7 @@ static int isl29028_set_proxim_sampling(struct isl29028_chip *chip, unsigned int sampling) { static unsigned int prox_period[] = {800, 400, 200, 100, 75, 50, 12, 0};



[PATCH 15/19] staging: iio: isl29028: made error messages consistent
Brian Masney writes: (Summary) 0) { - dev_err(dev, "Error in reading register %d, error %d\n", - ISL29028_REG_PROX_DATA, ret); 0) { - dev_err(dev, "%s(): write to reg %d failed, err = %d\n", - __func__, ISL29028_REG_CONFIGURE, ret); 0) { dev_err(&client->dev, - "%s(): write to reg %d failed, err = %d\n", __func__, - ISL29028_REG_TEST1_MODE, ret); 0) { dev_err(&client->dev, - "%s(): write to reg %d failed, err = %d\n", __func__, - ISL29028_REG_TEST2_MODE, ret);



[PATCH 13/19] staging: iio: isl29028: move failure logging into is ...
Brian Masney writes: (Summary) 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 23a4db8..0c8a878 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -79,18 +79,28 @@ struct isl29028_chip { static int isl29028_set_proxim_sampling(struct isl29028_chip *chip, unsigned int sampling) { + struct device *dev = regmap_get_device(chip->regmap); 0) { - dev_err(dev, - "Setting proximity samp_freq fail, err %d\n", - ret); - } - - chip->prox_sampling = val;



[PATCH 14/19] staging: iio: isl29028: move failure logging into is ...
Brian Masney writes: (Summary) 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 0c8a878..11e1673 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -121,11 +121,21 @@ static int isl29028_enable_proximity(struct isl29028_chip *chip) static int isl29028_set_als_scale(struct isl29028_chip *chip, int lux_scale) { + struct device *dev = regmap_get_device(chip->regmap); 0) { - dev_err(dev, - "Setting lux scale fail with error %d\n", ret); - } - - chip->lux_scale = val;



[PATCH 16/19] staging: iio: isl29028: remove unnecessary error log ...
Brian Masney writes: (Summary) If the call to isl29028_chip_init_and_power_on() in isl29028_probe() fails, then isl29028_probe() will log an error message. 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index a45d57c..3f01ad1 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -548,10 +548,8 @@ static int isl29028_probe(struct i2c_client *client, } ret = isl29028_chip_init_and_power_on(chip); 0) { - dev_err(&client->dev, "chip initialization failed: %d\n", ret);



[PATCH 19/19] staging: iio: isl29028: remove legacy device tree bi ...
Brian Masney writes: (Summary) 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index ae6896f..6be9aa7 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -611,7 +611,6 @@ static const struct i2c_device_id isl29028_id[] = { MODULE_DEVICE_TABLE(i2c, isl29028_id); static const struct of_device_id isl29028_of_match[] = { - { .compatible = "isl,isl29028", }, /* for backward compat., don't use */ { .compatible = "isil,isl29028", }, { }, };



[PATCH 18/19] staging: iio: isl29028: remove unnecessary parenthesis
Brian Masney writes: (Summary) 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index bda5183..ae6896f 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -330,7 +330,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, break; (val != 2000)) { + if (val != 125 && val != 2000) { dev_err(dev, "%s(): light: Lux scale %d is not in the set {125, 2000}\n", __func__, val);



[PATCH 17/19] staging: iio: isl29028: remove out of memory log message
Brian Masney writes: (Summary) If the call to devm_iio_device_alloc() fails, then isl29028_probe() logs a message saying that memory cannot be allocated. This patch removes that error message since the error code is passed on and the message is not necessary.
necessary.
Signed-off-by: Brian Masney 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 3f01ad1..bda5183 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -507,10 +507,8 @@ static int isl29028_probe(struct i2c_client *client, int ret; - if (!indio_dev) { - dev_err(&client->dev, "iio allocation fails\n");



[PATCH 03/19] staging: iio: isl29028: remove chip test and default ...
Brian Masney writes: (Summary) 42 +++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index c8e234d..4f819a8 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -416,29 +416,11 @@ static const struct iio_info isl29028_info = { .write_raw = isl29028_write_raw, }; 0) { - dev_err(dev, "%s(): write to reg %d failed, err = %d\n", - __func__, ISL29028_REG_TEST1_MODE, ret); 0) { - dev_err(dev, "%s(): write to reg %d failed, err = %d\n", - __func__, ISL29028_REG_TEST2_MODE, ret);



[PATCH 02/19] staging: iio: isl29028: remove enable flag from isl2 ...
Brian Masney writes: (Summary) 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 4e35d00..c8e234d 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -93,15 +93,13 @@ static int isl29028_set_proxim_sampling(struct isl29028_chip *chip, sel << } -static int isl29028_enable_proximity(struct isl29028_chip *chip, bool enable) +static int isl29028_enable_proximity(struct isl29028_chip *chip) { int ret; @@ -215,7 +213,7 @@ static int isl29028_proxim_get(struct isl29028_chip *chip, int *prox_data) int ret;



[PATCH 00/19] staging: iio: isl29028: staging cleanups
Brian Masney writes: (Summary) Brian Masney (19):
staging: iio: isl29028: remove nested if statements staging: iio: isl29028: remove enable flag from
isl29028_enable_proximity()
staging: iio: isl29028: remove chip test and defaults from isl29028_chip_init()
staging: iio: isl29028: add power management support staging: iio: isl29028: made alignment of #defines consistent staging: iio: isl29028: made alignment of variables in struct isl29028_chip consistent
staging: iio: isl29028: fix alignment of function arguments staging: iio: isl29028: combine isl29028_proxim_get() and isl29028_read_proxim()
staging: iio: isl29028: change newlines to improve readability staging: iio: isl29028: remove unused define ISL29028_DEV_ATTR staging: iio: isl29028: made column alignment in isl29028_channels consistent
staging: iio: isl29028: fix comparison between signed and unsigned integers
staging: iio: isl29028: move failure logging into
isl29028_set_proxim_samp



[PATCH 01/19] staging: iio: isl29028: remove nested if statements
Brian Masney writes: (Summary) 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index aa413e5..4e35d00 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -124,6 +124,9 @@ static int isl29028_set_als_ir_mode(struct isl29028_chip *chip, { int ret = 0; - if (chip->als_ir_mode != ISL29028_MODE_ALS) { - ret = isl29028_set_als_ir_mode(chip, ISL29028_MODE_ALS); 0) { - dev_err(dev, - "Error in enabling ALS mode err %d\n", ret); 0) { - dev_err(dev, - "Error in enabling IR mode err %d\n", ret);



Re: [PATCH 1/7] vfs - merge path_is_mountpoint() and path_is_mount ...
Ian Kent writes: (Summary) On Sat, 2016-12-03 at 23:29 +0000, Al Viro wrote: > On Sat, Dec 03, 2016 at 05:13:22AM +0000, Al Viro wrote: > * path_has_submounts() is broken.ÿ¿¿¿¿¿ÿ¿¿¿¿¿At the very least, it's > AB-BA between mount_lock and rename_lock.ÿ¿¿¿¿¿ÿ¿¿¿¿¿I would suggest trying to > put read_seqlock_excl(&mount_lock) around the call of d_walk() in there, > and using __lookup_mnt() in the callback (without retries on the mount_lock, > of course - read_seqlock_excl done on the outside is enough).ÿ¿¿¿¿¿ÿ¿¿¿¿¿I'm not sure > Fix for path_has_submounts() (as above) force-pushed.ÿ¿¿¿¿¿ÿ¿¿¿¿¿It does >



{standard input}:199: Error: unknown opcode
kbuild test robot writes: (Summary) Hi Rich,
Hi Rich,
FYI, the error/warning still remains.
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5
commit: b4214e41b7152b1964a3421a40251d202ae2d2c0 sh: add SMP support for J2 date: 4 months ago
config: sh-j2_defconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout b4214e41b7152b1964a3421a40251d202ae2d2c0 # save the attached .config to linux build tree
make.cross ARCH=sh
make.cross ARCH=sh
All errors (new one



arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3000' requires ...
kbuild test robot writes: (Summary) Hi Guenter,
Hi Guenter,
First bad commit (maybe != root cause):
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5
commit: 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e MIPS: VDSO: Fix build error with binutils 2.24 and earlier date: 11 months ago
config: mips-decstation_defconfig (attached as .config) compiler: mipsel-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e # save the attached .config to linux build tree
make.cross ARCH=mips



Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gi ...
kbuild test robot writes: (Summary) Hi Lino,
Hi Lino,
[auto build test ERROR on net-next/master]
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161126-202438 config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64
make.cross ARCH=sparc64
All errors (new ones prefixed by >>):
All errors (new ones prefixed by >>



Re: [PATCH 1/7] vfs - merge path_is_mountpoint() and path_is_mount ...
Ian Kent writes: (Summary) On Sat, 2016-12-03 at 05:13 +0000, Al Viro wrote: > * (fixed) __path_is_mountpoint() should _not_ treat NULL from > __lookup_mnt() as "nothing's mounted there" until it has checked > that mount_lock hadn't been touched - mount --move on something unrelated > * path_has_submounts() is broken.ÿ¿¿¿¿¿ÿ¿¿¿¿¿At the very least, it's > AB-BA between mount_lock and rename_lock.ÿ¿¿¿¿¿ÿ¿¿¿¿¿I would suggest trying to > and using __lookup_mnt() in the callback (without retries on the mount_lock, > of course - read_seqlock_excl done on the outside is enough).ÿ¿¿¿¿¿ÿ¿¿¿¿¿I'm not sure >



arch/mips/vdso/elf.S:1:0: error: '-march=r3000' requires '-mfp32'
kbuild test robot writes: (Summary) Hi Alex,
Hi Alex,
FYI, the error/warning still remains.
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5
commit: ebb5e78cc63417a35254a791de66e1cc84f963cc MIPS: Initial implementation of a VDSO date: 1 year, 1 month ago
config: mips-decstation_defconfig (attached as .config) compiler: mipsel-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout ebb5e78cc63417a35254a791de66e1cc84f963cc # save the attached .config to linux build tree
make.cross ARCH=mips
make.cross ARCH



Re: [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge
atull writes: On Sat, 3 Dec 2016, Moritz Fischer wrote:
On Sat, 3 Dec 2016, Moritz Fischer wrote:
Acked-by: Moritz Fischer
Acked-by: Alan Tull Acked-by: Alan Tull Moritz
Moritz



[PATCH] sysctl: Add KERN_CONT to deprecated_sysctl_warning()
Tetsuo Handa writes: (Summary) Do not break lines while printk()ing values.
Do not break lines while printk()ing values.
kernel: warning: process `tomoyo_file_tes' used the deprecated sysctl system call with kernel: 3.
kernel: 5.
kernel: 56.
kernel:
kernel:
Signed-off-by: Tetsuo Handa 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c index 6eb99c1..ece4b17 100644 --- a/kernel/sysctl_binary.c +++ b/kernel/sysctl_binary.c @@ -1354,8 +1354,8 @@ static void deprecated_sysctl_warning(const int *name, int nlen) "warning: process `%s' used the deprecated sysctl " "system call with ", current->comm);



RE: [PATCH 02/22] NTB: Add peer indexed ports NTB API
"Allen Hubbe" writes: From: Serge Semin
Secondary topologies, since port-number can be effectively used instead. Split into two patches please.
Split into two patches please.
I see no harm to the TOPO changes, though I wonder if they are necessary. I see no harm to the TOPO changes, though I wonder if they are necessary. 2.6.6
2.6.6
2.6.6



RE: [PATCH 06/22] NTB: Slightly alter link state NTB API
"Allen Hubbe" writes: (Summary) I plan to ack.
See comment on ntb_link_enable.
See comment on ntb_link_enable.
+ * ntb_link_enable() - enable the link of the ntb
Maybe: enable the local port ntb connection. The description that follows is good for B2B topology, but the description including "link training" might not be accurate for multi-port devices. The description that follows is good for B2B topology, but the description including "link training" might not be accurate for multi-port devices.



RE: [PATCH 03/22] NTB: Alter NTB API to support both inbound and o ...
"Allen Hubbe" writes: (Summary) + * 4) peer device maps outbound memory window so to have access to the shared > + * 3) Send translated base address and memory window index to a peer device > + * by another device memory region (it may fail if peer memory window > + * be allocated for memory windows between local device and peer device > + * @addr_align: OUT - the base alignment for translating the memory window > + * ntb_peer_mw_get_addr() - get map address of an outbound memory window > + * ntb_peer_mw_set_trans() - set a translation address of a memory window >



RE: [PATCH 04/22] NTB: Add messaging NTB API
"Allen Hubbe" writes: (Summary) + * ntb_msg_inbits() - get a bitsfield of inbound message registers status > + * The method returns the bitsfield of status and mask registers, which related > + * The method returns the bitsfield of status and mask registers, which related > + * Return: status bits of message registers > + * ntb_msg_clear_sts() - clear status bits of message registers > + * ntb_msg_set_mask() - set mask of message register status bits >



RE: [PATCH 08/22] NTB: Add T-Platforms copyrights to NTB API
"Allen Hubbe" writes: Signed-off-by: Serge Semin This patch has no comment, but instead...
This patch has no comment, but instead...
This can be squashed with your first commit of significant changes to each file. This can be squashed with your first commit of significant changes to each file. 2.6.6
2.6.6
2.6.6



Re: alpha: Checking for a failed kmalloc() in process_reloc_for_got()?
Jiri Kosina writes: On Sat, 3 Dec 2016, SF Markus Elfring wrote:
On Sat, 3 Dec 2016, SF Markus Elfring wrote:
function “kmalloc” also there?
*drumroll* it'd actually be a proper bugfix.
*drumroll* it'd actually be a proper bugfix.



RE: [PATCH 01/22] NTB: Move link state API being first in sources
"Allen Hubbe" writes: From: Serge Semin
done within ntb.h.
No harm. Please spellcheck the description.
No harm. Please spellcheck the description.
I think this and patch 7 can be squashed.
I think this and patch 7 can be squashed.
I plan to ack.
I plan to ack.
2.6.6
2.6.6



RE: [PATCH 07/22] NTB: Fix a few ntb.h issues
"Allen Hubbe" writes: From: Serge Semin
Fix some minor issues found in ntb.h file.
"Fix a few issues" is not a descriptive commit title or message. "Fix a few issues" is not a descriptive commit title or message. Please split: add NTB_SPEED_GEN4, ntb.h comments.
Please split: add NTB_SPEED_GEN4, ntb.h comments.
Changes look good and I will ack.
Changes look good and I will ack.
2.6.6
2.6.6
2.6.6



RE: [PATCH 05/22] NTB: Alter Scratchpads NTB API to support multi- ...
"Allen Hubbe" writes: From: Serge Semin
multi-port and have some set of Scratchpads.
I agree with addition of the peer port index, but I don't think s/idx/sidx/ for scratchpad index is necessary. I agree with addition of the peer port index, but I don't think s/idx/sidx/ for scratchpad index is necessary. 2.6.6
2.6.6
2.6.6



Re: [PATCH 1/7] vfs - merge path_is_mountpoint() and path_is_mount ...
Al Viro writes: (Summary) On Sat, Dec 03, 2016 at 05:13:22AM +0000, Al Viro wrote: > At the very least, it's > I would suggest trying to > put read_seqlock_excl(&mount_lock) around the call of d_walk() in there, > and using __lookup_mnt() in the callback (without retries on the mount_lock, > I'm not sure > that needs testing. As > it is, that function is broken in #work.autofs, same as it is in -mm and > It does need testing and profiling, obviously.



Re: [PATCH 1/2 v2] sched: fix find_idlest_group for fork
Matt Fleming writes: (Summary) Let me know if you'd like me to re-run with it applied.
re-run with it applied.
I don't see much of a difference, positive or negative, for the majority of the test machines, it's mainly a wash.
majority of the test machines, it's mainly a wash.
However, the following 4-cpu Xeon E5504 machine does show a nice win, with thread counts in the mid-range (note, the second column is number of hackbench groups, where each group has 40 tasks), of hackbench groups, where each group has 40 tasks), hackbench-process-pipes
4.9.0-rc6 4.9.0-rc6 4.9.0-rc6 tip-sched fix-fig-for-fork fix-sig Amean 1 0.2193 ( 0.00%) 0.2014 ( 8.14%) 0.1746 ( 20.39%) Amean 3 0.4489 ( 0.00%) 0.3544 ( 21.04%) 0.3284 ( 26.83%) Amean 5 0.6173 ( 0.00%) 0.4690 ( 24.02%) 0.4977 ( 19.37%) Amean 7 0.7323 ( 0.00%) 0.6367 ( 13.05%) 0.6267 ( 14.42%) Amean 12



Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS ...
Richard Cochran writes: On Mon, Nov 28, 2016 at 05:04:25PM -0600, Grygorii Strashko wrote: 200ms) for proper HW_TS_PUSH events reporting.
For proper reporting, you should make use of the interrupt. The small fifo (16 iirc) could very well overflow in 200 ms. The interrupt handler should read out the entire fifo at each interrupt. handler should read out the entire fifo at each interrupt. Thanks,
Richard
Richard
Richard



Re: [PATCH] ARM: dts: sunxi: Add num-cs for A20 spi nodes
kbuild test robot writes: (Summary) Hi Emmanuel,
Hi Emmanuel,
[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.9-rc7 next-20161202]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Emmanuel-Vadot/ARM-dts-sunxi-Add-num-cs-for-A20-spi-nodes/20161123-034323 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm-vexpress_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:
wget https://git.kernel.org/cgit/linux/kerne



Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer ...
Bhuvanchandra DV writes: On 12/03/2016 02:58 AM, Nikita Yushchenko wrote:
On 12/03/2016 02:58 AM, Nikita Yushchenko wrote:
enough, this flag will be set only if DMA was previously enabled, The check is to make sure the reconfiguration of DMA is done only when the baudrate is altered.
the baudrate is altered.
--
Bhuvan
Bhuvan
Nikita
Nikita



Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings
Florian Fainelli writes: (Summary) Le 12/03/16 ÿ¿¿¿¿¿3:35, Rob Herring a ÿ¿¿¿¿¿it :
+- clocks: Phandles to input clocks.
You are also missing mandatory properties:
You are also missing mandatory properties:
#address-cells = <1> and #size-cells = <0> #address-cells = <1> and #size-cells = <0> Can you make sure you have the same recipient list for both patches in this series so we can review both the binding and driver? both patches in this series so we can review both the binding and driver?



[PATCH v2 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' ...
Andrey Smirnov writes: (Summary) Remove 'fixed-link' nodes from DSA ports since they are not needed (they are not limiting link's speed and the ports will be configured to their maximux speed as a default)
maximux speed as a default)
Suggested-by: Andrew Lunn
Signed-off-by: Andrey Smirnov 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts index c0fc3f2..646c90c 100644 --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts @@ -97,10 +97,6 @@ phy-mode = "rgmii-txid"; - fixed-link { - speed = <1000>; - fixed-link { - speed = <1000>;



[PATCH v2 2/3] ARM: dts: vf610-zii-dev: Add .dts file for rev. C
Andrey Smirnov writes: (Summary) + + /* + * U121 + * + * Exposed signals: + * I/O0 - ENET_SWR_EN + * I/O1 - ESW1_RESETn + * I/O2 - ARINC_RESET + * I/O3 - DD1_IO_RESET + * I/O4 - ESW2_RESETn + * I/O5 - ESW3_RESETn + * I/O6 - ESW4_RESETn + * I/O8 - TP909 + * I/O9 - FEM_SEL + * I/O10 - WIFI_RESETn + * I/O11 - PHY_RSTn + * I/O12 - OPT1_SD + * I/O13 - OPT2_SD + * I/O14 - OPT1_TX_DIS + * I/O15 - OPT2_TX_DIS + */ + gpio6: sx1503@20 { + compatible = "semtech,sx1503q";



[PATCH v2 1/3] ARM: dts: vf610-zii-dev-rev-b: Remove leftover PWM ...
Andrey Smirnov writes: (Summary) Remove pwm0grp since it is:
Remove pwm0grp since it is:
a) Not referenced anywhere in the DTS file (unlike Tower board it is based on, this board does not use/expose FTM0)
is based on, this board does not use/expose FTM0)
b) Configures PTB2 and PTB3 in a way that contradicts pinctrl-mdio-mux
pinctrl-mdio-mux
Signed-off-by: Andrey Smirnov - VF610_PAD_PTB0__FTM0_CH0 0x1582 - VF610_PAD_PTB1__FTM0_CH1 0x1582 - VF610_PAD_PTB2__FTM0_CH2 0x1582 - VF610_PAD_PTB3__FTM0_CH3 0x1582 - >;