Subscribe: lkml.org
http://lkml.org/rss.php
Added By: Feedage Forager Feedage Grade B rated
Language: English
Tags:
child relid  drivers  entry  hyper trace  patch  struct  summary  trace vmbus  trace  usb  vmbus  writes summary  writes 
Rate this Feed
Rate this feedRate this feedRate this feedRate this feedRate this feed
Rate this feed 1 starRate this feed 2 starRate this feed 3 starRate this feed 4 starRate this feed 5 star

Comments (0)

Feed Details and Statistics Feed Statistics
Preview: lkml.org

lkml.org



lkml.org - the realtime linux kernel mailinglist archive



Last Build Date: Wed, 20 Sep 2017 22:01:52 +0200

 



Re: [PATCH 0/6] crypto: talitos - various fixes
christophe leroy writes: (Summary) I have resent it and it the same again, the serie is not dispatched on the linux-crypto list, but when I answer to a mail of the serie, the answer shows up.
of the serie, the answer shows up.
What could be the issue ?
What could be the issue ?
Christophe
Christophe
Le 20/09/2017 ÿ¿¿¿¿¿0:35, Christophe LEROY a ÿ¿¿¿¿¿itÿ¿¿¿¿¿: ÿ¿¿¿¿¿ 2 files changed, 36 insertions(+), 47 deletions(-) --- L'absence de virus dans ce courrier ÿ¿¿¿¿¿ctronique a ÿ¿¿¿¿¿ vÿ¿¿¿¿¿fiÿ¿¿¿¿¿par le logiciel antivirus Avast.



usb/media/pvrusb2: warning in pvr2_send_request_ex/usb_submit_urb
Andrey Konovalov writes: (Summary) There seems to be no check on endpoint type before submitting bulk urb in pvr2_send_request_ex().
in pvr2_send_request_ex().
usb 1-1: New USB device found, idVendor=2040, idProduct=7500 usb 1-1: New USB device strings: Mfr=0, Product=255, SerialNumber=0 usb 1-1: Product: a
gadgetfs: configuration #6
pvrusb2: Hardware description: WinTV HVR-1950 Model 750xx usb 1-1: BOGUS urb xfer, pipe 3 != type 1
------------[ cut here ]------------ WARNING: CPU: 1 PID: 2713 at drivers/usb/core/urb.c:449 usb_submit_urb+0xf8a/0x11d0 Modules linked in: CPU: 1 PID: 2713 Comm: pvrusb2-context Not tainted 4.14.0-rc1-42251-gebb2c2437d80 #210 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 task: ffff88006b7a18c0 task.stack: ffff880069978000 RIP: 0010:usb_submit_urb+0xf8a/0x11d0 drivers/usb/core/urb.c:448 RSP: 0018:ffff88006997f990 EFLAGS: 00010286 RAX: 0000000000000029 RBX: ffff880063661900 RCX: 0000000000000000 RDX: 0000000000000029 RSI: ffffffff86876d60 RDI: ffffed000d32



Re: [PATCH 2/3] drm/panel: add Kingdisplay kd097d04 panel driver
Sean Paul writes: (Summary) It would be great if you could #define some of these registers/values such that they're useful for people without access to the datasheet (like myself).
myself).
+static inline struct kingdisplay_panel *to_kingdisplay_panel(struct drm_panel *panel) 80 chars
80 chars
+ if (err < Any chance you can compress multiple commands into a few long writes?
compress multiple commands into a few long writes?
+ return err;
Let's log some errors for failures in this function Let's log some errors for failures in this function 1.9.1



Re: [PATCH v2] Input: adxl34x - fix gcc-7 -Wint-in-bool-context wa ...
Dmitry Torokhov writes: On Mon, Jul 17, 2017 at 01:43:51PM +0200, Arnd Bergmann wrote: v2: use FIFO_BYPASS instead of 0
Applied, thank you.
Applied, thank you.
2.9.0



[PATCH 3/3] [media] dvb-ttusb-budget: Adjust eight checks for null ...
SF Markus Elfring writes: (Summary) 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c index fef3c8554e91..2e97b1e64249 100644 --- a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c +++ b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c @@ -1572,7 +1572,7 @@ static void frontend_init(struct ttusb* ttusb) case 0x1003: // Hauppauge/TT Nova-USB-S budget (stv0299/ALPS BSRU6|BSBE1(tsa5059)) // try the stv0299 based first ttusb->fe = dvb_attach(stv0299_attach, &alps_stv0299_config, &ttusb->i2c_adap);



[PATCH 2/3] [media] dvb-ttusb-budget: Improve two size determinati ...
SF Markus Elfring writes: (Summary) ERROR: do not use assignment in if condition
ERROR: do not use assignment in if condition
Thus fix an affected source code place.
Thus fix an affected source code place.
* Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c index 38394c9ecc67..fef3c8554e91 100644 --- a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c +++ b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c @@ -1657,7 +1657,8 @@ static int ttusb_probe(struct usb_interface *intf, const struct usb_device_id *i if (intf->altsetting->desc.bInterfaceNumber != 1) return -ENODEV;



[PATCH 1/3] [media] dvb-ttusb-budget: Use common error handling co ...
SF Markus Elfring writes: (Summary) 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c index b842f367249f..38394c9ecc67 100644 --- a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c +++ b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c @@ -1675,8 +1675,7 @@ static int ttusb_probe(struct usb_interface *intf, const struct usb_device_id *i if (result < 0) { dprintk("%s: ttusb_alloc_iso_urbs - failed\n", __func__); } if (ttusb_init_controller(ttusb)) @@ -1687,11 +1686,9 @@ static int ttusb_probe(struct usb_interface *intf, const struct usb_device_id *i result = dvb_register_adapter(&ttusb->adapter, "Technotrend/Hauppauge Nova-USB", THIS_MODULE, &udev->dev, adapter_nr); 0) { - ttusb_free_iso_urbs(ttusb);



[PATCH 0/3] [media] TTUSB DVB Budget: Fine-tuning for three functi ...
SF Markus Elfring writes: (Summary) Date: Wed, 20 Sep 2017 21:03:45 +0200
Date: Wed, 20 Sep 2017 21:03:45 +0200
Three update suggestions were taken into account
from static source code analysis.
from static source code analysis.
Markus Elfring (3):
Use common error handling code in ttusb_probe()
Improve two size determinations in ttusb_probe()
Adjust eight checks for null pointers
Adjust eight checks for null pointers
drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c |



[PATCH 2/2] mm: oom: show unreclaimable slab info when kernel panic
"Yang Shi" writes: (Summary) oc->chosen != (void *)-1UL) { diff --git a/mm/slab.c b/mm/slab.c index 04dec48..4f4971c 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -4132,6 +4132,7 @@ void get_slabinfo(struct kmem_cache *cachep, struct slabinfo *sinfo) sinfo->shared = cachep->shared; + */ + list_for_each_entry(s, &slab_caches, list) { + if (!is_root_cache(s)) + continue; !defined(CONFIG_SLOB) void *memcg_slab_start(struct seq_file *m, loff_t *pos) { diff --git a/mm/slub.c b/mm/slub.c index 163352c..5c17c0a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5872,6 +5872,7 @@ void get_slabinfo(struct kmem_cache *s, struct slabinfo *sinfo) sinfo->num_slabs = nr_slabs;



[PATCH 1/2] tools: slabinfo: add "-U" option to show unreclaimable ...
"Yang Shi" writes: (Summary) @@ -132,6 +133,7 @@ static void usage(void) "-L|--Loss Sort by loss\n" "-X|--Xtotals Show extended summary information\n" "-B|--Bytes Show size in bytes\n" + "-U|--unreclaim Show unreclaimable slabs only\n" "\nValid debug options (FZPUT may be combined)\n" "a / A Switch on all debug options (=FZUP)\n" "- Switch off all debug options\n" @@ -568,6 +570,9 @@ static void slabcache(struct slabinfo *s) if (strcmp(s->name, "*") == 0) return; @@ -1346,6 +1351,7 @@ struct option opts[] = { { "Loss", no_argument, NULL, 'L'}, { "Xtotals", no_argument, NULL, 'X'}, { "Bytes", no_argument, NULL, 'B'}, + { "unreclaim", no_argument, NULL, 'U'}, { NULL, 0, NULL, 0 } };



[RFC v3] oom: capture unreclaimable slab info in oom message when ...
"Yang Shi" writes: (Summary) v2:
* Removed the original patch 1 (“mm: slab: output reclaimable flag in /proc/slabinfo”) since Christoph suggested it might break the compatibility and /proc/slabinfo is legacy * Added Christoph’s Acked-by
* Removed acquiring slab_mutex per Tetsuo’s comment * Removed acquiring slab_mutex per Tetsuo’s comment * Removed acquiring slab_mutex per Tetsuo’s comment Yang Shi (2):
tools: slabinfo: add "-U" option to show unreclaimable slabs only mm: oom: show unreclaimable slab info when kernel panic mm: oom: show unreclaimable slab info when kernel panic mm/oom_kill.c |



Re: [PATCH v7] blktrace: Fix potentail deadlock between delete & s ...
Jens Axboe writes: On 09/20/2017 11:32 AM, Steven Rostedt wrote:
Acked-by: Steven Rostedt (VMware) I'll take it through my tree, and I'll prune some of that comment as well (which should be a commit message thing, not a code comment). as well (which should be a commit message thing, not a code comment).



Re: [PATCH v7] blktrace: Fix potentail deadlock between delete & s ...
Waiman Long writes: On 09/20/2017 01:35 PM, Christoph Hellwig wrote:
should follow that.
It seems to be a general practice that we don't put detailed comments in the header files. The comment was put above the function with the first instance of the blk_trace_mutex. Yes, I agree that talking about the past history may not be applicable here. I will keep that in mind in the future.
future.
Thanks,
Longman
Longman
Longman
Longman



usb/media/smsusb: null-ptr-deref in smsusb_init_device
Andrey Konovalov writes: (Summary) There seems to be no check on the number of endpoints.
on the number of endpoints.
usb 1-1: New USB device found, idVendor=2040, idProduct=5530 usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0 gadgetfs: configuration #4
smsusb:smsusb_probe: board id=8, interface number 0 kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] PREEMPT SMP KASAN Modules linked in: CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 4.14.0-rc1-42251-gebb2c2437d80-dirty #208 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Workqueue: usb_hub_wq hub_event task: ffff88006bb26300 task.stack: ffff88006bba0000 RIP: 0010:smsusb_init_device+0x2f0/0xd10 drivers/media/usb/siano/smsusb.c:431 RSP: 0018:ffff88006bba6340 EFLAGS: 00010247 RAX: dffffc0000000000 RBX: ffff880063e10000 RCX: 1ffffffff1003ab8 RDX: 0000000000000000 RSI: ffff880063e10bac RDI: 0000000000000004 RBP: ffff88006bba6478 R08: ffffe



[RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling
Wolfram Sang writes: (Summary) +/** + * i2c_get_dma_safe_msg_buf() - get a DMA safe buffer for the given i2c_msg + * @msg: the message to be checked + * @threshold: the amount of byte from which using DMA makes sense + * + * Return: NULL if a DMA safe buffer was not obtained. + +/** + * i2c_release_dma_safe_msg_buf - release DMA safe buffer and sync with i2c_msg + * @msg: the message to be synced with + * @buf: the buffer obtained from i2c_get_dma_safe_msg_buf().



[RFC PATCH v5 0/6] i2c: document DMA handling and add helpers for it
Wolfram Sang writes: (Summary) If host drivers are not updated, they will continue to work like before.
will continue to work like before.
While the previous versions tried to magically apply bounce buffers when needed, it became clear that detecting DMA safe buffers is too fragile. Changes since v3: * completely redesigned Wolfram Sang (6): i2c: add a message flag for DMA safe buffers i2c: add helpers to ease DMA handling i2c: add docs to clarify DMA handling i2c: sh_mobile: use helper to decide if DMA is useful i2c: rcar: skip DMA if buffer is not safe i2c: dev: mark RDWR buffers as DMA_SAFE Documentation/i2c/DMA-considerations |



[RFC PATCH v5 3/6] i2c: add docs to clarify DMA handling
Wolfram Sang writes: (Summary) 58 ++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/i2c/DMA-considerations diff --git a/Documentation/i2c/DMA-considerations b/Documentation/i2c/DMA-considerations new file mode 100644 index 00000000000000..5a63355c6a9b6f --- /dev/null +++ b/Documentation/i2c/DMA-considerations @@ -0,0 +1,58 @@ +================= +Linux I2C and DMA +================= + +Given that I2C is a low-speed bus where largely small messages are transferred, +it is not considered a prime user of DMA access. It ensures data +is copied back to the message and a potentially used bounce buffer is freed:: + + i2c_release_dma_safe_msg_buf(msg, dma_buf);



[RFC PATCH v5 4/6] i2c: sh_mobile: use helper to decide if DMA is ...
Wolfram Sang writes: (Summary) 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index 6f2aaeb7c4fa15..b76399d8a3abd3 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -145,6 +145,7 @@ struct sh_mobile_i2c_data { struct dma_chan *dma_rx; struct sh_mobile_dt_config { @@ -548,6 +549,8 @@ static void sh_mobile_i2c_dma_callback(void *data) pd->pos = pd->msg->len; @@ -665,7 +668,8 @@ static int start_ch(struct sh_mobile_i2c_data *pd, struct i2c_msg *usr_msg, pd->pos = -1;



[RFC PATCH v5 5/6] i2c: rcar: skip DMA if buffer is not safe
Wolfram Sang writes: (Summary) This HW is prone to races, so it needs to setup new messages in irq context. That means we can't alloc bounce buffers if a message buffer is not DMA safe. 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 15d764afec3b29..8a2ae3e6c561c4 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -359,7 +359,7 @@ static void rcar_i2c_dma(struct rcar_i2c_priv *priv) int len; 8 bytes */ - if (IS_ERR(chan) || 8) + if (IS_ERR(chan) || 8 ||



[RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE
Wolfram Sang writes: (Summary) 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 6f638bbc922db4..bbc7aadb4c899d 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -280,6 +280,8 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client, res = PTR_ERR(rdwr_pa[i].buf); } + /* memdup_user allocates with GFP_KERNEL, so DMA is ok */ + rdwr_pa[i].flags |= I2C_M_DMA_SAFE; /* * If the message length is received from the slave (similar -- 2.11.0



[RFC PATCH v5 1/6] i2c: add a message flag for DMA safe buffers
Wolfram Sang writes: (Summary) */ #define I2C_M_TEN 0x0010 /* this is a ten bit chip address */ +#define I2C_M_DMA_SAFE 0x0200 /* the buffer of this message is DMA safe */ + /* makes only sense in kernelspace */ + /* userspace buffers are copied anyway */ #define I2C_M_RECV_LEN 0x0400 /* length will be first received byte */ #define I2C_M_NO_RD_ACK 0x0800 /* if I2C_FUNC_PROTOCOL_MANGLING */ #define I2C_M_IGNORE_NAK 0x1000 /* if I2C_FUNC_PROTOCOL_MANGLING */ -- 2.11.0



usb/media/cx231xx: null-ptr-deref in cx231xx_usb_probe
Andrey Konovalov writes: (Summary) There seems to be no check that the device actually contains an Interface Association Descriptor.
Descriptor.
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] PREEMPT SMP KASAN Modules linked in: CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 4.14.0-rc1-42251-gebb2c2437d80 #206 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Workqueue: usb_hub_wq hub_event task: ffff88006bb26300 task.stack: ffff88006bba0000 RIP: 0010:cx231xx_usb_probe+0x96a/0x32e0 drivers/media/usb/cx231xx/cx231xx-cards.c:1687 RSP: 0018:ffff88006bba63e0 EFLAGS: 00010246 RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 00000000fffff8f8 RDX: 0000000000000000 RSI: ffffffff86876d60 RDI: 0000000000000002 RBP: ffff88006bba65e8 R08: 0000000000000002 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff870a62e0 R13: ffff88005ba70028 R14: ffff880062c9aa80 R15: ffff880062c9b018 FS: 000000000



Re: [PATCH v5 2/2] tracing: Add support for preempt and irq enable ...
Joel Fernandes writes: (Summary) wrote: No '\n', otherwise you add a lot of whitespace to the trace: Sure will fix, thanks.
Sure will fix, thanks.
[..]
issues (run with lockdep enabled and you'll see all the splats). Ok, will fix, thanks!
Ok, will fix, thanks!
To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.



[PATCH] crypto: bcm: use of_device_get_match_data
Corentin Labbe writes: (Summary) 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c index 537a67483aa3..92e97a6da811 100644 --- a/drivers/crypto/bcm/cipher.c +++ b/drivers/crypto/bcm/cipher.c @@ -4818,7 +4818,6 @@ static int spu_dt_read(struct platform_device *pdev) struct device *dev = &pdev->dev; @@ -4826,14 +4825,12 @@ static int spu_dt_read(struct platform_device *pdev) /* Count number of mailbox channels */ spu->num_chan = of_count_phandle_with_args(dn, "mboxes", "#mbox-cells"); - if (!match) { + matched_spu_type = of_device_get_match_data(dev);



Re: [RFC PATCH v4 3/6] i2c: add docs to clarify DMA handling
Wolfram Sang writes: I usually add "::" at the preceding line, e. g.: Just in time: I added the '::' and will resubmit the new version in a minute.
minute.
Thanks for the pointers!
Thanks for the pointers!
Thanks for the pointers!
[unhandled content-type:application/pgp-signature]



Re: Vibrations in input vs. LED was Re: [PATCH v2 0/3] led: ledtri ...
Jacek Anaszewski writes: Hi,
Hi,
On 09/20/2017 01:15 PM, Pavel Machek wrote:
LEDs?
It could be used for software pwm trigger, there has been at least one an attempt to add such [0].
an attempt to add such [0].
[0] https://lkml.org/lkml/2015/4/27/493



[PATCH] crypto: omap: use of_device_get_match_data
Corentin Labbe writes: (Summary) 7 ++----- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 1f3686a1ebfa..fbec0a2e76dd 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -975,11 +975,10 @@ static int omap_aes_get_res_of(struct omap_aes_dev *dd, struct device *dev, struct resource *res) { struct device_node *node = dev->of_node; } #else diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index c40ac30ec002..86b89ace836f 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sham.c @@ -1944,11 +1944,10 @@ static int omap_sham_get_res_of(struct omap_sham_dev *dd, struct device *dev, struct resource *res) { struct device_node *node = dev->of_node;



Re: [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in ...
Kees Cook writes: (Summary) On Wed, Sep 20, 2017 at 6:04 AM, Oleg Nesterov wrote: Something like the untested patch (on top of this one) below? Yeah, I think this one looks good (modulo the -stable patch change). Yeah, I think this one looks good (modulo the -stable patch change). simply remove it?
I like doing these sanity checks -- this isn't fast-path at all. - }
Similarly, there's no reason to remove this check either. Similarly, there's no reason to remove this check either.



Re: [PATCH v2] vfs: introduce UMOUNT_WAIT which waits for umount c ...
Al Viro writes: (Summary) It
a) doesn't belong in umount(2) and
b) doesn't fix the race.
It might change the timing enough to have your specific reproducer survive, but that kind of approach is simply wrong.
but that kind of approach is simply wrong.
Incidentally, the name is a misnomer - it does *NOT* wait for completion of fs shutdown. Then observe how it's still alive, well and accessible in another.
accessible in another.
The only case that gets affected by it is when another mount is heading for shutdown and is in a very specific part of that.



Re: [PATCH] drm/i915: remove redundant variable hw_check
Daniel Vetter writes: On Thu, Sep 14, 2017 at 08:28:37PM +0100, Chris Wilson wrote: Reviewed-by: Chris Wilson Applied, thanks for patch&review.
-Daniel
-Daniel
https://lists.freedesktop.org/mailman/listinfo/dri-devel



usb/net/p54: trying to register non-static key in p54_unregister_leds
Andrey Konovalov writes: (Summary) INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 1 PID: 1404 Comm: kworker/1:1 Not tainted
4.14.0-rc1-42251-gebb2c2437d80-dirty #205
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Workqueue: usb_hub_wq hub_event
Call Trace:
__dump_stack lib/dump_stack.c:16
dump_stack+0x292/0x395 lib/dump_stack.c:52
register_lock_class+0x6c4/0x1a00 kernel/locking/lockdep.c:769 __lock_acquire+0x27e/0x4550 kernel/locking/lockdep.c:3385 lock_acquire+0x259/0x620 kernel/locking/lockdep.c:4002 flush_work+0xf0/0x8c0 kernel/workqueue.c:2886
__cancel_work_timer+0x51d/0x870 kernel/workqueue.c:2961 cancel_delayed_work_sync+0x1f/0x30 kernel/workqueue.c:3081 p54_unregister_leds+0x6c/0xc0 drivers/net/wireless/intersil/p54/led.c:160 p54_unregister_common+0x3d/0xb0 drivers/net/wireless/intersil/p54/main.c:856 p54u_disconnect+0x86/0x120 drivers/net/wireless/inters



Re: [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in ...
Kees Cook writes: On Wed, Sep 20, 2017 at 5:56 AM, Oleg Nesterov wrote: return ret;
Given how reference counting is done for filters, I'd be happier with leaving the get_seccomp_filter() as-is, and providing the __put_seccomp_filter() as the only change here (i.e. don't open-code the refcount_inc()).
the refcount_inc()).
-Kees
-Kees



[PATCH] crypto: stm32: use of_device_get_match_data
Corentin Labbe writes: (Summary) 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c index b585ce54a802..1d9285c62606 100644 --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -1408,11 +1408,10 @@ MODULE_DEVICE_TABLE(of, stm32_hash_of_match); static int stm32_hash_get_of_match(struct stm32_hash_dev *hdev, struct device *dev) { - const struct of_device_id *match; - if (!match) { + hdev->pdata = of_device_get_match_data(dev); } @@ -1420,8 +1419,6 @@ static int stm32_hash_get_of_match(struct stm32_hash_dev *hdev, err = of_property_read_u32(dev->of_node, "dma-maxburst", &hdev->dma_maxburst);



Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming
Daniel Vetter writes: On Tue, Sep 12, 2017 at 06:54:45PM +0100, Emil Velikov wrote: with a patch addressing the former
Maybe we should make this a written rule by patching Documentation/drivers/gpu? Would definitely make sense as part of this patch series.
patch series.
Thanks, Daniel
https://lists.freedesktop.org/mailman/listinfo/dri-devel



Re: [PATCH 1/1] userfaultfd: non-cooperative: fix fork use after free
Greg KH writes: (Summary) On Wed, Sep 20, 2017 at 08:04:13PM +0200, Andrea Arcangeli wrote: 1 file changed, 56 insertions(+), 10 deletions(-)


This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
for how to do this properly.






Re: usb/gadget: null-ptr-deref in dev_ioctl
Andrey Konovalov writes: (Summary) Attaching a simple repro of the issue just for reference.
repro of the issue just for reference.
think it will fix the problem you found.
This fixes the crash for me.
This fixes the crash for me.
Tested-by: Andrey Konovalov Thanks!
Thanks!
destroy_ep_files (dev);
#include
#include
#include
#include
#include
int main() { system("mkdir /dev/gadget &&



[PATCH v2 2/3] mtd: spi-nor: Altera ASMI Parallel II IP Core
matthew.gerlach@linux ... writes: (Summary) + +#define QSPI_ACTION_REG 0 +#define QSPI_ACTION_RST BIT(0) +#define QSPI_ACTION_EN BIT(1) +#define QSPI_ACTION_SC BIT(2) +#define QSPI_ACTION_CHIP_SEL_SFT 4 +#define QSPI_ACTION_DUMMY_SFT 8 +#define QSPI_ACTION_READ_BACK_SFT 16 + +#define QSPI_FIFO_CNT_REG 4 +#define QSPI_FIFO_DEPTH 0x200 +#define QSPI_FIFO_CNT_MSK 0x3ff +#define QSPI_FIFO_CNT_RX_SFT 0 +#define QSPI_FIFO_CNT_TX_SFT 12 + +#define QSPI_DATA_REG 0x8 + +#define QSPI_POLL_TIMEOUT_US 10000000 +#define QSPI_POLL_INTERVAL_US 5 + +struct altera_asmip2 { + void __iomem *csr_base; + +static struct platform_driver altera_asmip2_driver = { + .driver = { + .name = ALTERA_ASMIP2_DRV_NAME, + .of_match_table = altera_asmip2_id_table, + }, + .probe = altera_asmip2_probe, + .remove = altera_asmip2_remove, +};



[PATCH v2 1/3] dt-bindings: mtd: Altera ASMI Parallel II IP Core
matthew.gerlach@linux ... writes: (Summary) 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/altera-asmip2.txt diff --git a/Documentation/devicetree/bindings/mtd/altera-asmip2.txt b/Documentation/devicetree/bindings/mtd/altera-asmip2.txt new file mode 100644 index 0000000..2e58817 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/altera-asmip2.txt @@ -0,0 +1,15 @@ +* Altera ASMI Parallel II IP Core + +Devicetree bindings for an Altera ASMI Parallel II IP core connected to a +spi-nor flash chip. + +Example: + +qspi: spi@a0001000 { + compatible = "altr,asmi-parallel2-spi-nor";



[PATCH v2 3/3] mtd: spi-nor: add flag for reading dummy cycles fro ...
matthew.gerlach@linux ... writes: (Summary) @@ -231,7 +235,8 @@ static void altera_asmip2_unprep(struct spi_nor *nor, enum spi_nor_ops ops) } static int altera_asmip2_setup_banks(struct device *dev, - u32 bank, struct device_node *np) + u32 bank, struct device_node *np, + u32 flags) { const struct spi_nor_hwcaps hwcaps = { .mask = SNOR_HWCAPS_READ |



[PATCH v2 0/3] Altera ASMI Parallel II IP Core
matthew.gerlach@linux ... writes: (Summary) This driver was created based on feedback from Marek Vasut, Cyrill Pitchen, and Michal Suchanek regarding Version 2 of the Altera Quadspi Controller: https://lkml.org/lkml/2017/6/26/518 Quadspi Controller: https://lkml.org/lkml/2017/6/26/518 The overall problem with Version 2 of the Altera Quadspi Controller and its driver was the fact that there was much duplication of code and logic with the spi-nor framework. Matthew Gerlach (3):
dt-bindings: mtd: Altera ASMI Parallel II IP Core
mtd: spi-nor: Altera ASMI Parallel II IP Core
mtd: spi-nor: add flag for reading dummy cycles from nv cfg reg mtd: spi-nor: add flag for reading dummy cycles from nv cfg reg .../devicetree/bindings/mtd/altera-asmip2.txt |



Re: [PATCH 08/20] lightnvm: pblk: sched. metadata on write thread
Rakesh Pandit writes: (Summary) Hi Javier,
Hi Javier,
one small issue I found for error path while going through changes: one small issue I found for error path while going through changes: On Mon, Jun 26, 2017 at 11:57:17AM +0200, Javier Gonzÿ¿¿¿¿¿z wrote: ..
+ goto fail_free_smeta;
For this error path the the goto label at end doesn't free up resources correctly. + if (!emeta->buf) { > + } else { > + while (--i >= 0) { >



Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning
Joe Perches writes: On Wed, 2017-09-20 at 19:53 +0200, Helge Deller wrote: Just in case some patch get's backported.
I think probably not.
I think probably not.
There are relatively few references and
modifications are unlikely to be backported.
modifications are unlikely to be backported.
modifications are unlikely to be backported.



Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documen ...
Corentin Labbe writes: (Summary) On Tue, Sep 19, 2017 at 09:49:52PM -0500, Rob Herring wrote: we don't.
Putting mdio-mux as a child of it (the mdio node) give me: [ 18.175338] libphy: stmmac: probed
[ 18.175379] mdio_bus stmmac-0: /soc/ethernet@1c30000/mdio/mdio-mux has invalid PHY address [ 18.175408] mdio_bus stmmac-0: scan phy mdio-mux at address 0 [ 18.175450] mdio_bus stmmac-0: scan phy mdio-mux at address 1 [ 18.175482] mdio_bus stmmac-0: scan phy mdio-mux at address 2 [ 18.175513] mdio_bus stmmac-0: scan phy mdio-mux at address 3 [ 18.175544] mdio_bus stmmac-0: scan phy mdio-mux at address 4 [ 18.175575] mdio_bus stmmac-0: scan phy mdio-mux at address 5 [ 18.175607] mdio_bus stmmac-0: scan phy mdio-mux at address 6 [ 18.175638] mdio_bus stmmac-0: scan phy mdio-mux at address 7 [ 18.175669] mdio_bus stmmac-0: scan phy mdio-mux at address 8 [ 18.175700] mdio_bus stmmac-0: scan phy mdio-mux at address 9 [ 18.175731] mdio_bus stmmac-0: scan phy mdio-mux at address 10 [ 18.175762] mdi



Re: [PATCH v5 2/2] tracing: Add support for preempt and irq enable ...
Steven Rostedt writes: (Summary) wrote:
+ TP_printk("caller=%pF parent=%pF\n",
No '\n', otherwise you add a lot of whitespace to the trace: No '\n', otherwise you add a lot of whitespace to the trace: ==== -0 [002] d..1 252.533022: preempt_enable: caller=cpuidle_enter_state+0xfe/0x3a0 parent=cpuidle_enter+0x17/0x20 rcu_preempt-8 [002] ...1 252.533063: preempt_enable: caller=schedule+0x4a/0x90 parent=schedule+0x4a/0x90 rcu_preempt-8 [002] d..1 252.533065: preempt_disable: caller=_raw_spin_lock_irqsave+0x2f/0x60 parent=lock_timer_base+0x81/0xa0 rcu_preempt-8 [002] ...1 252.533066: preempt_enable: caller=_raw_spin_unlock_irqrestore+0x4a/0x80 parent=try_to_del_timer_sync+0x44/0x60 rcu_preempt-8 [002] d..1 252.533067: preempt_disable: caller=_raw_spin_lock_irqsave+0x2f/0x60 parent=prepare_to_swait+0x22/0x70 rcu_preempt-8 [002] ...1 252.533067: preempt_enable: caller=_raw_spin_unlock_irqrestore+0x4a/0x80 parent=prepare_to_swait+0x63



Re: [RFC PATCH v4 3/6] i2c: add docs to clarify DMA handling
Mauro Carvalho Chehab writes: (Summary) something like:
foo(void *bar);
foo(void *bar);
as asterisks mean italics. It would complain about the lack of an end asterisk.
an end asterisk.
In order to avoid that, and to place them into a box using monotonic fonts, I usually add "::" at the preceding line, e. g.: ::
::
foo(void *bar);
foo(void *bar);
or:
or:
some description::
some description::
foo(void *bar)
foo(void *bar)
on all functions (even the ones that don't use asterisks, as the html output looks nicer.
html output looks nicer.
I double-checked this patch: it doesn't contain anything that would cause warnings or parse errors.



Re: Rough notes from sys_membarrier() lightning BoF
Andy Lutomirski writes: (Summary) wrote:
with future arch-specific optimizations.
Fair enough.
Fair enough.
That being said, on same architectures (which may well be all but PPC), it might be nice if the registration call literally just sets a flag in the mm saying that it happened so that the registration enforcement can be done.
enforcement can be done.
Any other ideas ? Any approach seems better ?
It doesn't seem to make much difference to me.
It doesn't seem to make much difference to me.
It doesn't seem to make much difference to me.



Congratulations!!!!!!!
"Worldwide Internet." writes: (Summary) Worldwide Internet 2017 Eradication Promotion.
Head Office Address,
37 Yatch Basin Marina Offices,
Upon Tyen Liverpool,
London, United Kingdom.
Email: worldwideinternetlotto@email.com
Email: worldwideinternetlotto@email.com
Email: worldwideinternetlotto@email.com
Open the attached file for your Email Address winning Notification From Worldwide Internet 2017 Eradication Promotion.
Worldwide Internet 2017 Eradication Promotion.
Worldwide Internet 2017 Eradication Promotion.
CONGRATULATIONS ONCE AGAIN...
Yours faithfully,
Mrs.Mercy Nolly.
(secretary)
(secretary)
(secretary)
[unhandled content-type:application/vnd.openxmlformats-officedocument.wordprocessingml.document]



Re: Rough notes from sys_membarrier() lightning BoF
Mathieu Desnoyers writes: (Summary) ----- On Sep 20, 2017, at 12:02 PM, Andy Lutomirski luto@kernel.org wrote: > This series purports to solve two problems, ppc barriers and x86 > solves the latter problem given the complete lack of x86 or isync code > using this registration mechanism on x86 even when you implement > Unless I've misunderstood, the only real issue on x86 is that > PPC appears to track > If so, how does TLB flush on ppc >



Re: [v4,0/3] Workaround for bus/slot reset on Cavium cn8xxx root ports
Alex Williamson writes: (Summary) wrote: 2 files changed, 16 insertions(+)
2 files changed, 16 insertions(+)
Looks ok to me, for series:
Looks ok to me, for series:
Reviewed-by: Alex Williamson I am curious why we're happy targeting this quirk at a single device ID while at the same time trying to expand the ACS quirk to a notable fraction of the Cavium PCI device ID address space. Thanks, Alex
Alex
Alex



Re: A patch slipped through the cracks?
Mauro Carvalho Chehab writes: Em Wed, 20 Sep 2017 19:17:17 +0200
Lubomir Rintel escreveu:
Lubomir Rintel escreveu:
patch.
Not sure what happened, but I tagged is as new. I'll take a look on it later, when I start handling patches for Kernel 4.15. on it later, when I start handling patches for Kernel 4.15. Regards,
Maur
Maur
Thanks,
Mauro
Mauro
Mauro



[PATCH 1/1] userfaultfd: non-cooperative: fix fork use after free
Andrea Arcangeli writes: (Summary) + /* + * If fork_event list wasn't empty and in turn + * the event wasn't already released by fork + * (the event is allocated on fork kernel + * stack), put the event back to its place in + * the event_wq. + } else { + /* + * Here the fork thread aborted and the + * refcount from the fork thread on fork_nctx + * has already been released.



[PATCH] ARM: davinci_all_defconfig: enable CMA options
Suman Anna writes: (Summary) 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index 4d432cf1ee79..bd0cf22f9ceb 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -34,6 +34,7 @@ CONFIG_DAVINCI_MUX_WARNINGS=y CONFIG_DAVINCI_RESET_CLOCKS=y CONFIG_PREEMPT=y CONFIG_AEABI=y +CONFIG_CMA=y CONFIG_SECCOMP=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 @@ -56,6 +57,7 @@ CONFIG_NETFILTER=y CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y # CONFIG_FW_LOADER is not set +CONFIG_DMA_CMA=y CONFIG_DA8XX_MSTPRI=y CONFIG_MTD=m CONFIG_MTD_TESTS=m -- 2.13.1



[PATCH v2] docs: fix location of document that got moved
Henning Schild writes: (Summary) commit 9d85025b0418 ("docs-rst: create an user's manual book") renamed the document mentioned in the header. 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index ce7181ea60fa..b5f1ae5d3217 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -4,7 +4,8 @@ * Copyright (C) 1997 Richard Gÿ¿¿¿¿¿ * * binfmt_misc detects binaries via a magic or filename extension and invokes - * a specified wrapper. See Documentation/admin-guide/binfmt-misc.rst for more + * details.



Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang
Dmitry Vyukov writes: (Summary) On Wed, Sep 20, 2017 at 7:46 PM, H. wrote: interrupts or exceptions would also smash the redzone. But it's the same for user-space signals, the first thing a signal should do is to skip the redzone. I guess interrupt handlers should switch to interrupt stack which avoids smashing redzone altogether. In my experience frames in leaf functions can have pretty large performance penalty. Wonder if we have we considered changing interrupt/exception handlers to avoid smashing redzones and disable leaf frames?
leaf frames?
leaf frames?



Re: usb/gadget: null-ptr-deref in dev_ioctl
Alan Stern writes: (Summary) I haven't tried it myself yet, but I think it will fix the problem you found.
think it will fix the problem you found.
Alan Stern
Alan Stern
Alan Stern
Alan Stern
Index: usb-4.x/drivers/usb/gadget/legacy/inode.c
=================================================================== --- usb-4.x.orig/drivers/usb/gadget/legacy/inode.c +++ usb-4.x/drivers/usb/gadget/legacy/inode.c @@ -28,7 +28,7 @@ #include + dev->state == STATE_DEV_UNBOUND) { + /* Not bound to a UDC */ + } else if (gadget->ops->ioctl) { + ++dev->udc_usage;



Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang
"H. Peter Anvin" writes: On 09/20/17 10:38, Dmitry Vyukov wrote:
below used part of stack in leaf functions.
In the kernel it does. Redzoning is not allowed in the kernel, because interrupts or exceptions would also smash the redzone. interrupts or exceptions would also smash the redzone. -hpa
-hpa
-hpa



Re: [PATCH 02/16] hyper-v: trace vmbus_on_message()
Steven Rostedt writes: (Summary) wrote: + );
Whenever you have two trace events with everything the same but the TP_printk(), you can save a little space by using DEFINE_EVENT_PRINT() TP_printk(), you can save a little space by using DEFINE_EVENT_PRINT() DECLARE_EVENT_CLASS(vmbus_hdr_msg,
TP_PROTO(const struct vmbus_channel_message_header *hdr), TP_ARGS(hdr),
TP_STRUCT__entry(__field(unsigned int, msgtype),
TP_fast_assign(__entry->msg = hdr->msgtype;), TP_printk("msgtype=%d", __entry->msgtype) );
);
DEFINE_EVENT_PRINT(vmbus_hdr_msg, vmbus_on_msg_dpc, TP_PROTO(const struct vmbus_channel_message_header *hdr), TP_ARGS(hdr),
TP_printk("message %u received", __entry->msgtype));



Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning
Helge Deller writes: On 20.09.2017 19:38, Joe Perches wrote:
is unclear and would prefer something like:
Is it worth to mention, that it's still needed in older kernels? Just in case some patch get's backported.
Just in case some patch get's backported.
Helge
Helge
Helge



Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang
Josh Poimboeuf writes: (Summary) On Tue, Sep 19, 2017 at 08:18:23PM -0500, Josh Poimboeuf wrote: the frame pointer setup.
So it turns out that for GCC 7, it works as described above: the global register variable results in the frame pointer getting set up before *all* inline asm.
*all* inline asm.
But for GCC 6, it doesn't work that way. The global register variable has no such effect.
has no such effect.
So we need both the global register variable *and* the output constraint after all. Will post another patch after some more testing.



Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang
Josh Poimboeuf writes: On Wed, Sep 20, 2017 at 10:32:43AM -0700, H. Peter Anvin wrote: because we have a call assembly instruction?
It's frame pointer convention. Without it, if dumping the stack from the called function, a function will get skipped in the stack trace. the called function, a function will get skipped in the stack trace.



Re: [v4,0/3] Workaround for bus/slot reset on Cavium cn8xxx root ports
Jon Masters writes: On 09/12/2017 05:40 AM, Vadim Lomovtsev wrote:
On 09/12/2017 05:40 AM, Vadim Lomovtsev wrote:
Comments/objections/acks/nacks ?
Any more comments?
Any more comments?
Jon.
Jon.
2 files changed, 16 insertions(+)
2 files changed, 16 insertions(+)



Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang
"H. Peter Anvin" writes: On 09/19/17 11:45, Josh Poimboeuf wrote:
negligible.
Again, probably negligible, but why do we need a frame pointer just because we have a call assembly instruction?
because we have a call assembly instruction?
-hpa
-hpa
-hpa



Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning
Joe Perches writes: (Summary) 11 +++++++++-- ÿ¿¿¿¿¿1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index dd2c262aebbf..71f3273d5913 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5762,18 +5762,25 @@ sub process { ÿ¿¿¿¿¿ ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿for (my $count = $linenr; $count++) { ÿ¿¿¿¿¿ my $fmt = get_quoted_string($lines[$count - 1], raw_line($count, 0)); - if ($fmt =~ /(\%[\*\d\.]*p(?![\WFfSsBKRraEhMmIiUDdgVCbGNO]).)/) { + if ($fmt =~ /(\%[\*\d\.]*p(?![\WSsBKRraEhMmIiUDdgVCbGNO]).)/) { ÿ¿¿¿¿¿ $bad_extension = $1; ÿ¿¿¿¿¿ } ÿ¿¿¿¿¿ } ÿ¿¿¿¿¿ if ($bad_extension ne "") { ÿ¿¿¿¿¿ my $stat_real = raw_line($linenr, 0); $count++) { ÿ¿¿¿¿¿ $stat_real = $stat_real .



Re: [PATCH v2] vfs: introduce UMOUNT_WAIT which waits for umount c ...
Jaegeuk Kim writes: (Summary) 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/fs/namespace.c b/fs/namespace.c index f8893dc6a989..f2c15c4f6e23 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -21,6 +21,7 @@ #include #define MNT_DETACH 0x00000002 /* Just detach from the tree */ #define MNT_EXPIRE 0x00000004 /* Mark for expiry */ #define UMOUNT_NOFOLLOW 0x00000008 /* Don't follow symlink on umount */ +#define UMOUNT_WAIT 0x00000010 /* Wait to unmount completely */ #define UMOUNT_UNUSED 0x80000000 /* Flag guaranteed to be unused */ /* sb->s_iflags */ -- 2.14.0.rc1.383.gd1ce394fe2-goog



Re: [PATCH 2/2] x86/asm: Fix inline asm call constraints for clang
Dmitry Vyukov writes: On Wed, Sep 20, 2017 at 7:32 PM, H. Peter Anvin wrote: because we have a call assembly instruction?
I think we need just the frame itself and RSP pointing below this frame. If we don't have a frame, CALL instruction will smash whatever RSP happens to point to. Compiler doesn't have to setup RSP to point below used part of stack in leaf functions.
below used part of stack in leaf functions.
below used part of stack in leaf functions.



Re: [PATCH v7] blktrace: Fix potentail deadlock between delete & s ...
Christoph Hellwig writes: + */
Comments about previous locking schemes really don't have a business in the code - those are remarks for the commit logs. And in general please explain the locking scheme near the data that they proctect it, as locks should always protected data, not code and the comments should follow that.
should follow that.
should follow that.



Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission
levipearson@gmail ... writes: (Summary) If you enqueue a frame with a scheduled launch time that ends up more than half a second late, it is considered by the hardware to be scheduled *in the future* at the offset belonging to the next second after the 1-second window wraps around.
wraps around.
So *slightly* late (<<.5sec late) frames could be scheduled as normal, but approaching .5sec late frames would have to either be dropped or have their schedule changed to avoid blocking the queue for a large fraction of a second.
fraction of a second.
I don't like the idea of changing the scheduled time, and anything that is close to half a second late is most likely useless.



[PATCH] staging: rtl8723bs: avoid null pointer dereference on pmlm ...
Colin King writes: (Summary) However, a previous call to rtw_free_mlme_priv_ie_data can also dereference pmlmepriv, so move this call so that it is only called if pmlmepriv non-null.
called if pmlmepriv non-null.
Detected by CoverityScan, CID#1077739 ("Dereference before null check") Detected by CoverityScan, CID#1077739 ("Dereference before null check") Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Colin Ian King



[PATCH v2] Makefile: kselftest and kselftest-clean fail for make O ...
Shuah Khan writes: (Summary) 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 64cbc66cebca..7735fc32b24e 100644 --- a/Makefile +++ b/Makefile @@ -1169,14 +1169,13 @@ headers_check: headers_install # --------------------------------------------------------------------------- # Kernel selftest - PHONY += kselftest kselftest: - $(Q)$(MAKE) -C tools/testing/selftests run_tests + $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests PHONY += kselftest-clean kselftest-clean: - $(Q)$(MAKE) -C tools/testing/selftests clean + $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean PHONY += kselftest-merge kselftest-merge: -- 2.11.0



Re: [PATCH v7] blktrace: Fix potentail deadlock between delete & s ...
Steven Rostedt writes: (Summary) Christoph,
Christoph,
Can you give an acked-by for this patch?
Can you give an acked-by for this patch?
Jens,
Jens,
You want to take this through your tree, or do you want me to? If you want it, here's my:
If you want it, here's my:
Acked-by: Steven Rostedt (VMware) Acked-by: Steven Rostedt (VMware) -- Steve
-- Steve
-- Steve
On Wed, 20 Sep 2017 13:26:11 -0400
Waiman Long



Re: [PATCH 01/11] Makefile: kselftest and kselftest-clean fail for ...
Shuah Khan writes: (Summary) On 09/19/2017 09:39 PM, Masahiro Yamada wrote:
$(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean I started with the simpler logic and decided to add explicit check for KBUILD_SRC due to isolate some error I was seeing from sub-make. for KBUILD_SRC due to isolate some error I was seeing from sub-make. I am not seeing any issues with the simplified. I am not seeing any issues with the simplified. Thanks for the review.
Thanks for the review.
-- Shuah
-- Shuah
-- Shuah



Re: [PATCH v4 5/6] iommu/iova: Extend rbtree node caching
Robin Murphy writes: (Summary) On 20/09/17 13:59, Tomasz Nowicki wrote:
iovad->cached32_node to IOVA3.
That in itself is intentional and correct - the cached node is where we *start* searching for free space, so if the topmost 32-bit pfn is free, we want to start from whichever node represents the next-highest pfn. Even if more 64-bit IOVAs were allocated below IOVA3 before the next 32-bit allocation, walking through those is better that walking all the way down from the anchor.
way down from the anchor.
However, you have made me realise that if IOVA3 were freed before the next 32-bit allocation things we'd only update cached_node and leave cached32_node with a stale pointer...
cached32_node with a stale pointer...
I'll get a v5 out tomorrow (and keep the new stuff at the end of the series this time)
series this time)
Thanks,
Robin.
Robin.
Robin.



[PATCH v7] blktrace: Fix potentail deadlock between delete & sysfs ops
Waiman Long writes: (Summary) 24 ++++++++++++++++++------ 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index aebe676..048be4a 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -854,6 +854,9 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id) kobject_init(&q->kobj, &blk_queue_ktype); + */ + /** * blk_trace_ioctl: - handle the ioctls associated with tracing * @bdev: the block device @@ -665,7 +677,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg) if (!q) return -ENXIO; if (attr == &dev_attr_enable) { if (value) @@ -1814,7 +1826,7 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev, } out_unlock_bdev: - mutex_unlock(&bdev->bd_mutex);



[PATCH 01/16] hyper-v: trace vmbus_on_msg_dpc()
Vitaly Kuznetsov writes: (Summary) 2 ++ 5 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 drivers/hv/hv_trace.c create mode 100644 drivers/hv/hv_trace.h diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile index 39c9b2c08d33..ad791e00230f 100644 --- a/drivers/hv/Makefile +++ b/drivers/hv/Makefile @@ -2,7 +2,9 @@ obj-$(CONFIG_HYPERV) += hv_vmbus.o obj-$(CONFIG_HYPERV_UTILS) += hv_utils.o obj-$(CONFIG_HYPERV_BALLOON) += hv_balloon.o +CFLAGS_hv_trace.o = -I$(src) + hv_vmbus-y := vmbus_drv.o \ hv.o connection.o channel.o \ - channel_mgmt.o ring_buffer.o + channel_mgmt.o ring_buffer.o hv_trace.o hv_utils-y := hv_util.o hv_kvp.o hv_snapshot.o hv_fcopy.o hv_utils_transport.o diff --git a/drivers/hv/hv_trace.c b/drivers/hv/hv_trace.c new file mode 100644 index 000000000000..df47acd01a81 --- /dev/null +++ b/drivers/hv/hv_trace.c @@ -0,0 +1,4 @@ +#include "hyperv_vmbus.h" + +#define CREATE_TRACE_POINTS +#include "hv_trace.h" diff --git a/drivers/hv/hv_trace.h b/drivers/hv/hv_trace.h new file mode 100644 index 000



[PATCH 02/16] hyper-v: trace vmbus_on_message()
Vitaly Kuznetsov writes: (Summary) 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 060df71c2e8b..ddeebba8971e 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -1170,6 +1170,8 @@ void vmbus_onmessage(void *context) hdr = (struct vmbus_channel_message_header *)msg->u.payload; +TRACE_EVENT(vmbus_on_message, + TP_PROTO(const struct vmbus_channel_message_header *hdr), + TP_ARGS(hdr), + TP_STRUCT__entry(__field(unsigned int, msgtype)), + TP_fast_assign(__entry->msgtype = hdr->msgtype), + TP_printk("processing message %u", __entry->msgtype) + );



[PATCH 03/16] hyper-v: trace vmbus_onoffer()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_onoffer, + TP_PROTO(const struct vmbus_channel_offer_channel *offer), + TP_ARGS(offer), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(u8, monitorid) + __field(u16, is_ddc_int) + __field(u32, connection_id) + __array(char, if_type, 16) + __array(char, if_instance, 16) + __field(u16, chn_flags) + __field(u16, mmio_mb) + __field(u16, sub_idx) + ), + TP_fast_assign(__entry->child_relid = offer->child_relid;



[PATCH 04/16] hyper-v: trace vmbus_onoffer_rescind()
Vitaly Kuznetsov writes: (Summary) + /* * The offer msg and the corresponding rescind msg * from the host are guranteed to be ordered - diff --git a/drivers/hv/hv_trace.h b/drivers/hv/hv_trace.h index 8376fdf9d054..d2a5a97dcf2a 100644 --- a/drivers/hv/hv_trace.h +++ b/drivers/hv/hv_trace.h @@ -59,6 +59,14 @@ TRACE_EVENT(vmbus_onoffer, ) ); +TRACE_EVENT(vmbus_onoffer_rescind, + TP_PROTO(const struct vmbus_channel_rescind_offer *offer), + TP_ARGS(offer), + TP_STRUCT__entry(__field(u32, child_relid)), + TP_fast_assign(__entry->child_relid = offer->child_relid), + TP_printk("child_relid 0x%x", __entry->child_relid) + );



Re: I/O hangs after resuming from suspend-to-ram
Martin Steigerwald writes: (Summary) My findings are different:
My findings are different:
On 4.12.10 with CONFIG_HZ=1000, CONFIG_PREEMPT=y and optimizations for Intel Core/newer Xeon I see this:
Core/newer Xeon I see this:
1) Running with CFQ: No hang after resume
1) Running with CFQ: No hang after resume
2) Running with scsi_mod.use_blk_mq=1 + BFQ: Hang after resume within first 1-2 days.
days.
However with 4.12.9 with CONFIG_HZ=250, CONFIG_PREEMPT_VOLUNTARY=y + no CPU optimizations: No hang after resume, no matter whether I use CFQ or scsi-mq + BFQ.
BFQ.
Both configs attached.
Both configs attached.
Also 4.13.2 with CFQ is stable so far.
Also 4.13.2 with CFQ is stable so far.
I am looking forward for fixes to appear in 4.13.x with x>2 and retest with BFQ then, unless you have a different advice.
then, unless you have a different advice.
I am running Debian Sid/Experimental from BTRFS RAID 1 with two SSDs I am running Debian Sid/Experimental from BTRFS RAI



[PATCH 06/16] hyper-v: trace vmbus_ongpadl_created()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_ongpadl_created, + TP_PROTO(const struct vmbus_channel_gpadl_created *gpadlcreated), + TP_ARGS(gpadlcreated), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(u32, gpadl) + __field(u32, status) + ), + TP_fast_assign(__entry->child_relid = gpadlcreated->child_relid; + ), + TP_printk("child_relid 0x%x, gpadl 0x%x, creation_status %d", + __entry->child_relid, __entry->gpadl, __entry->status + ) + );



[PATCH 10/16] hyper-v: trace vmbus_open()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_open, + TP_PROTO(const struct vmbus_channel_open_channel *msg, int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(u32, openid) + __field(u32, gpadlhandle) + __field(u32, target_vp) + __field(u32, offset) + __field(int, ret) + ), + TP_fast_assign( + __entry->child_relid = msg->child_relid;



[PATCH 09/16] hyper-v: trace vmbus_request_offers()
Vitaly Kuznetsov writes: (Summary) 8 ++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index a9a1fc1424c6..5c39388545f5 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -1218,9 +1218,11 @@ int vmbus_request_offers(void) msg->msgtype = CHANNELMSG_REQUESTOFFERS; +TRACE_EVENT(vmbus_request_offers, + TP_PROTO(int ret), + TP_ARGS(ret), + TP_STRUCT__entry(__field(int, ret)), + TP_fast_assign(__entry->ret = ret), + TP_printk("sending ret %d", __entry->ret) + );



[PATCH 08/16] hyper-v: trace vmbus_onversion_response()
Vitaly Kuznetsov writes: (Summary) 11 +++++++++++ 2 files changed, 14 insertions(+) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 1ff2cc064850..a9a1fc1424c6 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -1121,6 +1121,9 @@ static void vmbus_onversion_response( unsigned long flags; +TRACE_EVENT(vmbus_onversion_response, + TP_PROTO(const struct vmbus_channel_version_response *response), + TP_ARGS(response), + TP_STRUCT__entry( + __field(u8, ver) + ), + TP_fast_assign(__entry->ver = response->version_supported; + ), + TP_printk("version_supported %d", __entry->ver) + );



[PATCH 14/16] hyper-v: trace vmbus_negotiate_version()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_negotiate_version, + TP_PROTO(const struct vmbus_channel_initiate_contact *msg, int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __field(u32, ver) + __field(u32, target_vcpu) + __field(int, ret) + __field(u64, int_page) + __field(u64, mon_page1) + __field(u64, mon_page2) + ), + TP_fast_assign( + __entry->ver = msg->vmbus_version_requested;



[PATCH 12/16] hyper-v: trace vmbus_establish_gpadl()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_establish_gpadl_header, + TP_PROTO(const struct vmbus_channel_gpadl_header *msg, int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(u32, gpadl) + __field(u16, range_buflen) + __field(u16, rangecount) + __field(int, ret) + ), + TP_fast_assign( + __entry->child_relid = msg->child_relid; + +TRACE_EVENT(vmbus_establish_gpadl_body, + TP_PROTO(const struct vmbus_channel_gpadl_body *msg, int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __field(u32, msgnumber) + __field(u32, gpadl) + __field(int, ret) + ), + TP_fast_assign( + __entry->msgnumber = msg->msgnumber;



[PATCH 15/16] hyper-v: trace vmbus_release_relid()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_release_relid, + TP_PROTO(const struct vmbus_channel_relid_released *msg, int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(int, ret) + ), + TP_fast_assign( + __entry->child_relid = msg->child_relid; + ), + TP_printk("sending child_relid 0x%x, ret %d", + __entry->child_relid, __entry->ret + ) + );



Re: [mainline][DLPAR][Oops] OF: ERROR: Bad of_node_put() on /cpus
Tyrel Datwyler writes: (Summary) On 09/20/2017 04:39 AM, Michael Ellerman wrote:
Testing a fix, will report back.
So, that patch slipped past me. Not only is the parent reference not ours to drop, but when I went and looked at dlpar_cpu_add() I also noticed that of_node_put() was done on the parent prior to the call to dlpar_attach_node(). With the addition of "parent" to the dlpar_attach_node() parameter list dlpar_cpu_add() needs to be fixed up to hold the "parent" reference until after dlpar_attach_node() returns.



[PATCH 16/16] hyper-v: trace vmbus_send_tl_connect_request()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_send_tl_connect_request, + TP_PROTO(const struct vmbus_channel_tl_connect_request *msg, + int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __array(char, guest_id, 16) + __array(char, host_id, 16) + __field(int, ret) + ), + TP_fast_assign( + memcpy(__entry->guest_id, &msg->guest_endpoint_id.b, 16);



[PATCH 13/16] hyper-v: trace vmbus_teardown_gpadl()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_teardown_gpadl, + TP_PROTO(const struct vmbus_channel_gpadl_teardown *msg, int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(u32, gpadl) + __field(int, ret) + ), + TP_fast_assign( + __entry->child_relid = msg->child_relid; + ), + TP_printk("sending child_relid 0x%x, gpadl 0x%x, ret %d", + __entry->child_relid, __entry->gpadl, __entry->ret + ) + );



[PATCH 11/16] hyper-v: trace vmbus_close_internal()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_close_internal, + TP_PROTO(const struct vmbus_channel_close_channel *msg, int ret), + TP_ARGS(msg, ret), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(int, ret) + ), + TP_fast_assign( + __entry->child_relid = msg->child_relid; + ), + TP_printk("sending child_relid 0x%x, ret %d", __entry->child_relid, + __entry->ret) + );



[PATCH 07/16] hyper-v: trace vmbus_ongpadl_torndown()
Vitaly Kuznetsov writes: (Summary) 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index af2448e245ca..1ff2cc064850 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -1076,6 +1076,8 @@ static void vmbus_ongpadl_torndown( gpadl_torndown = (struct vmbus_channel_gpadl_torndown *)hdr; +TRACE_EVENT(vmbus_ongpadl_torndown, + TP_PROTO(const struct vmbus_channel_gpadl_torndown *gpadltorndown), + TP_ARGS(gpadltorndown), + TP_STRUCT__entry(__field(u32, gpadl)), + TP_fast_assign(__entry->gpadl = gpadltorndown->gpadl), + TP_printk("gpadl 0x%x", __entry->gpadl) + );



[PATCH 05/16] hyper-v: trace vmbus_onopen_result()
Vitaly Kuznetsov writes: (Summary) +TRACE_EVENT(vmbus_onopen_result, + TP_PROTO(const struct vmbus_channel_open_result *result), + TP_ARGS(result), + TP_STRUCT__entry( + __field(u32, child_relid) + __field(u32, openid) + __field(u32, status) + ), + TP_fast_assign(__entry->child_relid = result->child_relid; + ), + TP_printk("child_relid 0x%x, openid %d, status %d", + __entry->child_relid, __entry->openid, __entry->status + ) + );



[PATCH 00/16] Hyper-V: add tracing to VMBus module and trace all m ...
Vitaly Kuznetsov writes: (Summary) Vitaly Kuznetsov (16): hyper-v: trace vmbus_on_msg_dpc() hyper-v: trace vmbus_on_message() hyper-v: trace vmbus_onoffer() hyper-v: trace vmbus_onoffer_rescind() hyper-v: trace vmbus_onopen_result() hyper-v: trace vmbus_ongpadl_created() hyper-v: trace vmbus_ongpadl_torndown() hyper-v: trace vmbus_onversion_response() hyper-v: trace vmbus_request_offers() hyper-v: trace vmbus_open() hyper-v: trace vmbus_close_internal() hyper-v: trace vmbus_establish_gpadl() hyper-v: trace vmbus_teardown_gpadl() hyper-v: trace vmbus_negotiate_version() hyper-v: trace vmbus_release_relid() hyper-v: trace vmbus_send_tl_connect_request() drivers/hv/Makefile |



Re: [PATCH] sched/fair: Force balancing on nohz balance if local g ...
Brendan Jackman writes: Hi Peter, Josef,
Hi Peter, Josef,
Do you have any thoughts on this one?
Do you have any thoughts on this one?
On Mon, Aug 07 2017 at 16:39, Brendan Jackman wrote: goto force_balance;
goto force_balance;



Re: [media] Siano: Use common error handling code in smsusb_init_d ...
SF Markus Elfring writes: (Summary) smsusb_term_device(intf); The call tree is:
Thanks for your constructive information.
Thanks for your constructive information.
Thanks for your constructive information.
How do you think about another implementation detail in this function then? How do you think about another implementation detail in this function then? be executed before “smsusb_term_device(intf);” in one if branch?
in one if branch?
Regards,
Markus
Markus
Markus



Re: [RFC PATCH v4 3/6] i2c: add docs to clarify DMA handling
Wolfram Sang writes: (Summary) Hi Mauro,
Hi Mauro,
ReST. The only complaint I got was
The only complaint I got was
WARNING: document isn't included in any toctree
WARNING: document isn't included in any toctree
which makes sense because I renamed it only temporarily to *.rst which makes sense because I renamed it only temporarily to *.rst will complain and how it will look in html.
So, no complaints from Sphinx and the HTML output looks good IMO.



A patch slipped through the cracks?
Lubomir Rintel writes: (Summary) Hi,
Hi,
we're trying to get this reasonably trivial patch [1] applied for more than a year and four attempts now. (I'm not including it in this message so that this message won't be ignored for the same reason the submissions were, whatever they are.)
submissions were, whatever they are.)
[1] https://patchwork.linuxtv.org/patch/40862/
[1] https://patchwork.linuxtv.org/patch/40862/
I have no idea what went wrong. But someone *please* look into this and apply the patch.
patch.
Thank you
Lubo
Lubo
Lubo



Re: [PATCH v2] sched/fair: Sync task util before slow-path wakeup
Brendan Jackman writes: (Summary) Hi Peter,
Hi Peter,
Ping.
Ping.
Log of previous discussion: https://patchwork.kernel.org/patch/9876769/ Log of previous discussion: https://patchwork.kernel.org/patch/9876769/ Cheers,
Brendan
Brendan
On Tue, Aug 08 2017 at 09:55, Brendan Jackman wrote: new_cpu = select_idle_sibling(p, prev_cpu, new_cpu); new_cpu = select_idle_sibling(p, prev_cpu, new_cpu);



Re: [PATCH] ARM: unaligned.h: Use an arch-specific version
Robin Murphy writes: (Summary) Hi Romain,
Hi Romain,
On 20/09/17 16:18, Romain Izard wrote:
and must be avoided.
Nit: that sentence is not really true - there are CPUs without MMUs that still support alignment checking (e.g. ARM1156), and more importantly the rotation thing is only true for LDR/LDRH - LDM always just ignores the bottom two bits of the address, and LDRD doesn't make any guarantee at all of what you might get back (and stores are even worse). I think it suffices to say that in the absence of alignment checking, the results of unaligned accesses are inconsistent and impossible to rely upon. Robin.
Robin.
+#endif /* __ASM_ARM_UNALIGNED_H */
+#endif /* __ASM_ARM_UNALIGNED_H */



Re: [PATCH v2 37/40] tracing: Add inter-event hist trigger Documen ...
Tom Zanussi writes: (Summary) The underlying mechanism hasn't changed much though, which is that basically a synthetic event is generated using variables from one or more 'matching' events, where 'matching' means that an event with a matching key was found in a histogram for that event, and the value of the variable associated with it is used for the corresponding param when generating the synthetic event. So when the event that defines the onmatch() action occurs, the matching events having the same key as the onmatch() synthetic event params are looked up and if all are found the onmatch() action generates the synthetic events using those matching variables.
variables.
Though that's still all true, the most common use case consists of two events, the event the onmatch() is defined on and the matching.event specified as onmatch(matching.event).



Applied "ASoC: arizona: Add support for setting the output volume ...
Mark Brown writes: (Summary) The patch
The patch
ASoC: arizona: Add support for setting the output volume limits ASoC: arizona: Add support for setting the output volume limits has been applied to the asoc tree at
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. ++i) { + if (arizona->pdata.out_vol_limit[i]) + regmap_update_bits(arizona->regmap, + ARIZONA_DAC_VOLUME_LIMIT_1L + i * 4, + ARIZONA_OUT1L_VOL_LIM_MASK, + arizona->pdata.out_vol_limit[i]);